Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: Source/devtools/front_end/toolbox/MediaQueryInspector.js

Issue 478953002: DevTools: [MQI] add tooltips for ruler serifs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/toolbox/MediaQueryInspector.js
diff --git a/Source/devtools/front_end/toolbox/MediaQueryInspector.js b/Source/devtools/front_end/toolbox/MediaQueryInspector.js
index 0127465d399d4968b83ebc4bb9145150db61a9fa..5793baed2b58f616f4ba201e19c579799882d31a 100644
--- a/Source/devtools/front_end/toolbox/MediaQueryInspector.js
+++ b/Source/devtools/front_end/toolbox/MediaQueryInspector.js
@@ -357,6 +357,7 @@ WebInspector.MediaQueryInspector.prototype = {
var thresholds = this._mediaQueryThresholds();
for (var i = 0; i < thresholds.length; ++i) {
var thresholdElement = this._rulerDecorationLayer.createChild("div", "media-inspector-threshold-serif");
+ thresholdElement.title = thresholds[i] + "px";
dgozman 2014/08/16 17:54:13 Do you think we should round the value?
lushnikov 2014/08/16 18:18:52 They are integers - no need for conversion here.
thresholdElement._value = thresholds[i];
thresholdElement.style.left = (thresholds[i] - this._offset) / zoomFactor + "px";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698