Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 478923005: Revert of Oilpan: Move more code of RenderObject destructors to destroy(). (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Move more code of RenderObject destructors to destroy(). (patchset #1 of https://codereview.chromium.org/459353002/) Reason for revert: Caused crashes in ImageQualityController::highQualityRepaintTimerFired(). Original issue's description: > Oilpan: Move more code of RenderObject destructors to destroy(). > > Like [1] and [2]. We should do it in general. > > [1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023 > [2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029 > > BUG=398342 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180046 TBR=oilpan-reviews@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=398342 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -49 lines) Patch
M Source/core/rendering/RenderBlock.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +1 line, -17 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Oilpan: Move more code of RenderObject destructors to destroy().
6 years, 4 months ago (2014-08-18 05:14:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/478923005/1
6 years, 4 months ago (2014-08-18 05:14:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 180424
6 years, 4 months ago (2014-08-18 05:15:42 UTC) #3
haraken
6 years, 4 months ago (2014-08-18 05:23:35 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698