Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 478923005: Revert of Oilpan: Move more code of RenderObject destructors to destroy(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderBoxModelObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBlock.cpp
diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp
index fb4dd16de83b758328d9a3be7075a17a4c9e7fa3..7a4db09eda33c4fdc5d87bc6e6582270b9c086ae 100644
--- a/Source/core/rendering/RenderBlock.cpp
+++ b/Source/core/rendering/RenderBlock.cpp
@@ -216,7 +216,7 @@
appendImageIfNotNull(images, blockStyle.shapeOutside()->image());
}
-void RenderBlock::removeFromGlobalMaps()
+RenderBlock::~RenderBlock()
{
if (hasColumns())
gColumnInfoMap->take(this);
@@ -224,22 +224,6 @@
removeBlockFromDescendantAndContainerMaps(this, gPercentHeightDescendantsMap, gPercentHeightContainerMap);
if (gPositionedDescendantsMap)
removeBlockFromDescendantAndContainerMaps(this, gPositionedDescendantsMap, gPositionedContainerMap);
-}
-
-RenderBlock::~RenderBlock()
-{
-#if !ENABLE(OILPAN)
- removeFromGlobalMaps();
-#endif
-}
-
-void RenderBlock::destroy()
-{
- RenderBox::destroy();
-#if ENABLE(OILPAN)
- // RenderObject::removeChild called in destory() depends on gColumnInfoMap.
- removeFromGlobalMaps();
-#endif
}
void RenderBlock::willBeDestroyed()
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderBoxModelObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698