Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 478853003: [Sync] Have bookmarks use a slower nudge delay to better handle automated writes (Closed)

Created:
6 years, 4 months ago by Nicolas Zea
Modified:
6 years, 4 months ago
Reviewers:
haitaol1
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Sync] Have bookmarks use a slower nudge delay to better handle automated writes Now that its expected that extensions will be modifying bookmarks, we should attempt to coalesce more of their writes into a single sync cycle. BUG=401600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291486

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M sync/internal_api/sync_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 32 (0 generated)
Nicolas Zea
PTAL. This is a stopgap measure until I can get server-controlled nudge delays working.
6 years, 4 months ago (2014-08-18 23:07:22 UTC) #1
Nicolas Zea
ping?
6 years, 4 months ago (2014-08-19 22:21:25 UTC) #2
haitaol1
lgtm
6 years, 4 months ago (2014-08-20 17:28:10 UTC) #3
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-20 17:28:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/1
6 years, 4 months ago (2014-08-20 17:29:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 19:18:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 19:56:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5216)
6 years, 4 months ago (2014-08-20 19:56:01 UTC) #8
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-20 20:02:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/20001
6 years, 4 months ago (2014-08-20 20:05:26 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 21:58:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 22:01:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55151) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7946)
6 years, 4 months ago (2014-08-20 22:01:17 UTC) #13
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-22 02:13:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/20001
6 years, 4 months ago (2014-08-22 02:15:09 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-22 02:18:56 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:21:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/56138) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8646)
6 years, 4 months ago (2014-08-22 02:21:18 UTC) #18
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-22 17:19:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/60001
6 years, 4 months ago (2014-08-22 17:20:27 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 18:33:45 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 18:37:24 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8645)
6 years, 4 months ago (2014-08-22 18:37:25 UTC) #23
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-22 19:29:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/60001
6 years, 4 months ago (2014-08-22 19:30:27 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:33:37 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:36:28 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8689)
6 years, 4 months ago (2014-08-22 19:36:28 UTC) #28
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-22 19:44:34 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/478853003/60001
6 years, 4 months ago (2014-08-22 19:45:21 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:51:04 UTC) #31
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 20:00:47 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (60001) as 291486

Powered by Google App Engine
This is Rietveld 408576698