Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 478853003: [Sync] Have bookmarks use a slower nudge delay to better handle automated writes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_manager_impl.h ('k') | sync/internal_api/sync_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index a444b918d071049dae8f803eb7ec24ffe5b14988..f0fecbc45c2ba1af12bfdffe0309a534474402b4 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -63,7 +63,7 @@ namespace {
// Delays for syncer nudges.
static const int kDefaultNudgeDelayMilliseconds = 200;
-static const int kPreferencesNudgeDelayMilliseconds = 2000;
+static const int kSlowNudgeDelayMilliseconds = 2000;
static const int kSyncRefreshDelayMsec = 500;
static const int kSyncSchedulerDelayMsec = 250;
@@ -120,6 +120,7 @@ class NudgeStrategy {
switch (type) {
case AUTOFILL:
return ACCOMPANY_ONLY;
+ case BOOKMARKS:
case PREFERENCES:
case SESSIONS:
case FAVICON_IMAGES:
@@ -146,9 +147,9 @@ class NudgeStrategy {
break;
case CUSTOM:
switch (model_type) {
+ case BOOKMARKS:
case PREFERENCES:
- delay = TimeDelta::FromMilliseconds(
- kPreferencesNudgeDelayMilliseconds);
+ delay = TimeDelta::FromMilliseconds(kSlowNudgeDelayMilliseconds);
break;
case SESSIONS:
case FAVICON_IMAGES:
@@ -1149,8 +1150,8 @@ int SyncManagerImpl::GetDefaultNudgeDelay() {
}
// static.
-int SyncManagerImpl::GetPreferencesNudgeDelay() {
- return kPreferencesNudgeDelayMilliseconds;
+int SyncManagerImpl::GetSlowNudgeDelay() {
+ return kSlowNudgeDelayMilliseconds;
}
} // namespace syncer
« no previous file with comments | « sync/internal_api/sync_manager_impl.h ('k') | sync/internal_api/sync_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698