Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/findit/chromium_deps.py

Issue 478763003: [Findit] Bug fixing and implemented some feature requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed a bug in intersection Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/findit/chromium_deps.py
diff --git a/tools/findit/chromium_deps.py b/tools/findit/chromium_deps.py
index f86dd93c803a465bfb8423107cecb3a6e1d421e1..d2a94d9b5e478475e8a1bc1757007a170d803b03 100644
--- a/tools/findit/chromium_deps.py
+++ b/tools/findit/chromium_deps.py
@@ -5,6 +5,7 @@
import base64
import json
import os
+import urllib2
from common import utils
@@ -65,8 +66,13 @@ def _GetComponentName(path, host_dirs):
def _GetContentOfDEPS(url):
- _, content = utils.GetHttpClient().Get(url, timeout=60)
- return content
+ try:
+ _, content = utils.GetHttpClient().Get(url, timeout=60)
+ return content
+
+ # TODO(jeun): Handle HTTP Errors, such as 404.
+ except urllib2.HTTPError:
Martin Barbella 2014/08/22 02:24:13 Please include some kind of retry logic here. Just
jeun 2014/08/22 22:58:43 Done.
+ return ''
def GetChromiumComponents(chromium_revision,

Powered by Google App Engine
This is Rietveld 408576698