[Findit] Bug fixing and implemented some feature requests.

tools/findit/chromium_deps.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 import os
+import urllib2
 
 from common import utils
 
 
 _THIS_DIR = os.path.abspath(os.path.dirname(__file__))
 CONFIG = json.loads(open(os.path.join(_THIS_DIR,
                                       'deps_config.json'), 'r').read())
 
 
 class _VarImpl(object):
@@ skipping 40 matching lines @@
       if name in components_renamed:
         return components_renamed[name].lower()
       else:
         return name.lower()
 
   # Unknown path, return the whole path as component name.
   return '_'.join(path.split('/'))
 
 
 def _GetContentOfDEPS(url):
-  _, content = utils.GetHttpClient().Get(url, timeout=60)
-  return content
+  try:
+    _, content = utils.GetHttpClient().Get(url, timeout=60)
+    return content
+
+  # TODO(jeun): Handle HTTP Errors, such as 404.
+  except urllib2.HTTPError:

[Martin Barbella, 2014/08/22 02:24:13]

Please include some kind of retry logic here. Just define a constant for number
of attempts (something like 3-5 should be good enough).

[jeun, 2014/08/22 22:58:43]

Done.

+    return ''
 
 
 def GetChromiumComponents(chromium_revision,
                           os_platform='unix',
                           deps_file_downloader=_GetContentOfDEPS):
   """Return a list of components used by Chrome of the given revision.
 
   Args:
     chromium_revision: The revision of the Chrome build.
     os_platform: The target platform of the Chrome build, eg. win, mac, etc.
@@ skipping 118 matching lines @@
         'path': path,
         'rolled': new_component['revision'] != old_revision,
         'name': new_component['name'],
         'old_revision': old_revision,
         'new_revision': new_component['revision'],
         'repository': new_component['repository'],
         'repository_type': new_component['repository_type']
     }
 
   return components