Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 478543004: Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo (Closed)

Created:
6 years, 4 months ago by perkj_chrome
Modified:
6 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo originally landed in https://codereview.chromium.org/442313002/ The only difference is that the test has been disabled on DrMemory since it times out. Notice that many WebRtcBrowsertests are disabled due to the same reason. BUG=403070, 398844 Committed: https://crrev.com/88e174977fb987fa2ca049a07bd2c8c716ee2066 Cr-Commit-Position: refs/heads/master@{#292142}

Patch Set 1 #

Patch Set 2 : Disabled under TSAN 2 due to http://crbug.com/408006. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 3 chunks +23 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
perkj_chrome
perkj@chromium.org changed reviewers: + phoglund@chromium.org
6 years, 3 months ago (2014-08-26 13:19:19 UTC) #1
perkj_chrome
Phoglund - can you take a look again and I can try to land this ...
6 years, 3 months ago (2014-08-26 13:20:05 UTC) #2
phoglund_chromium
lgtm
6 years, 3 months ago (2014-08-27 07:10:36 UTC) #3
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 3 months ago (2014-08-27 10:30:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/478543004/1
6 years, 3 months ago (2014-08-27 10:31:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 10:44:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 10:45:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9447) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/9450) ios_rel_device_ninja ...
6 years, 3 months ago (2014-08-27 10:45:37 UTC) #8
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 3 months ago (2014-08-27 12:07:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/478543004/20001
6 years, 3 months ago (2014-08-27 12:08:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 13:39:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (20001) as c02be4d8e74fd8e38f8bacf69f37a3234c247994
6 years, 3 months ago (2014-08-27 14:24:19 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88e174977fb987fa2ca049a07bd2c8c716ee2066
Cr-Commit-Position: refs/heads/master@{#292142}

Powered by Google App Engine
This is Rietveld 408576698