Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 478543004: Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled under TSAN 2 due to http://crbug.com/408006. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/test/data/media/peerconnection-call.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/process/process_handle.h" 7 #include "base/process/process_handle.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 CanSetupVideoCallWith4To3AspectRatio 159 CanSetupVideoCallWith4To3AspectRatio
160 #endif 160 #endif
161 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, 161 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
162 MAYBE_CanSetupVideoCallWith4To3AspectRatio) { 162 MAYBE_CanSetupVideoCallWith4To3AspectRatio) {
163 const std::string javascript = 163 const std::string javascript =
164 "callAndExpectResolution({video: {mandatory: {minWidth: 960," 164 "callAndExpectResolution({video: {mandatory: {minWidth: 960,"
165 "maxAspectRatio: 1.333}}}, 960, 720);"; 165 "maxAspectRatio: 1.333}}}, 960, 720);";
166 MakeTypicalPeerConnectionCall(javascript); 166 MakeTypicalPeerConnectionCall(javascript);
167 } 167 }
168 168
169 // Flaky on TSAN v2. http://crbug.com/408006
170 #if defined(THREAD_SANITIZER)
171 #define MAYBE_CanSetupVideoCallAndDisableLocalVideo \
172 DISABLED_CanSetupVideoCallAndDisableLocalVideo
173 #else
174 #define MAYBE_CanSetupVideoCallAndDisableLocalVideo \
175 CanSetupVideoCallAndDisableLocalVideo
176 #endif
177 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
178 MAYBE_CanSetupVideoCallAndDisableLocalVideo) {
179 const std::string javascript =
180 "callAndDisableLocalVideo({video: true});";
181 MakeTypicalPeerConnectionCall(javascript);
182 }
183
169 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY) 184 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
170 // Timing out on ARM linux, see http://crbug.com/240376 185 // Timing out on ARM linux, see http://crbug.com/240376
171 #define MAYBE_CanSetupAudioAndVideoCall DISABLED_CanSetupAudioAndVideoCall 186 #define MAYBE_CanSetupAudioAndVideoCall DISABLED_CanSetupAudioAndVideoCall
172 #else 187 #else
173 #define MAYBE_CanSetupAudioAndVideoCall CanSetupAudioAndVideoCall 188 #define MAYBE_CanSetupAudioAndVideoCall CanSetupAudioAndVideoCall
174 #endif 189 #endif
175 190
176 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, MAYBE_CanSetupAudioAndVideoCall) { 191 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, MAYBE_CanSetupAudioAndVideoCall) {
177 MakeTypicalPeerConnectionCall("call({video: true, audio: true});"); 192 MakeTypicalPeerConnectionCall("call({video: true, audio: true});");
178 } 193 }
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 602
588 base::DeleteFile(unique_dump_file, false); 603 base::DeleteFile(unique_dump_file, false);
589 } 604 }
590 } 605 }
591 606
592 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, CreateOfferWithOfferOptions) { 607 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, CreateOfferWithOfferOptions) {
593 MakeTypicalPeerConnectionCall("testCreateOfferOptions();"); 608 MakeTypicalPeerConnectionCall("testCreateOfferOptions();");
594 } 609 }
595 610
596 } // namespace content 611 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/test/data/media/peerconnection-call.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698