Issue 478523003: Fix unprefixed transitions when experimental features flag is off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478523003: Fix unprefixed transitions when experimental features flag is off (Closed)

Created:
6 years, 4 months ago by Timothy Loh

Modified:
6 years, 4 months ago

Reviewers:
alancutter (OOO until 2018)

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix unprefixed transitions when experimental features flag is off The patch https://codereview.chromium.org/415613002 unintentionally made unprefixed transitions depend on the animations unprefixed flag as it made us exit out of prefixingVariantForPropertyId when the flag was off. BUG=404001 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180327

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -81 lines)			Patch
	A	LayoutTests/virtual/stable/animations-unprefixed/transitions-unprefixed.html	View		1 chunk	+20 lines, -0 lines	0 comments	Download
	M	Source/core/css/CSSProperty.h	View		1 chunk	+53 lines, -81 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alancutter (OOO until 2018)

lgtm, looking forward to these hand rolled switches being turned into auto generated alias code.

6 years, 4 months ago (2014-08-15 04:33:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/478523003/1

6 years, 4 months ago (2014-08-15 04:36:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180327

Expand Messages | Collapse Messages