Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 415613002: Merge CSSPropertyNames.in and SVGCSSPropertyNames.in with CSSProperties.in (Closed)

Created:
6 years, 5 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, eseidel, esprehn, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Merge CSSPropertyNames.in and SVGCSSPropertyNames.in with CSSProperties.in This patch is part 2 of merging the CSS .in files. Having a single .in file for listing CSS properties makes it both easier to add new properties and add new property flags. BUG=396992 TBR=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180151

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase and small clean up #

Patch Set 6 : rebase to not depend on cascade #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : remove currently unused builder_unreachable #

Patch Set 9 : fix crash without experimental flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -585 lines) Patch
A LayoutTests/virtual/stable/animations-unprefixed/animation-name-style-setter.html View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/stable/animations-unprefixed/animation-name-style-setter-expected.txt View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/build/scripts/css_properties.py View 1 2 3 4 5 6 7 2 chunks +10 lines, -1 line 0 comments Download
M Source/build/scripts/make_css_property_names.py View 1 2 3 4 5 3 chunks +18 lines, -44 lines 0 comments Download
M Source/core/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/core_generated.gyp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -9 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 4 5 6 7 7 chunks +42 lines, -3 lines 0 comments Download
M Source/core/css/CSSProperty.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/CSSPropertyNames.in View 1 2 3 4 5 1 chunk +0 lines, -421 lines 0 comments Download
D Source/core/css/SVGCSSPropertyNames.in View 1 chunk +0 lines, -51 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/scripts/generate_supported_css.py View 1 2 3 1 chunk +18 lines, -45 lines 0 comments Download

Messages

Total messages: 39 (0 generated)
Timothy Loh
Part 2 of merging CSS .in files, depends on https://codereview.chromium.org/410953002/.
6 years, 5 months ago (2014-07-24 07:47:13 UTC) #1
lushnikov
On 2014/07/24 07:47:13, Timothy Loh wrote: > Part 2 of merging CSS .in files, depends ...
6 years, 5 months ago (2014-07-25 11:43:58 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/415613002/diff/120001/Source/build/scripts/css_properties.py File Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/415613002/diff/120001/Source/build/scripts/css_properties.py#newcode28 Source/build/scripts/css_properties.py:28: 'builder_unreachable': False, Unused flag.
6 years, 4 months ago (2014-08-11 05:02:22 UTC) #3
Timothy Loh
https://codereview.chromium.org/415613002/diff/120001/Source/build/scripts/css_properties.py File Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/415613002/diff/120001/Source/build/scripts/css_properties.py#newcode28 Source/build/scripts/css_properties.py:28: 'builder_unreachable': False, On 2014/08/11 05:02:22, alancutter wrote: > Unused ...
6 years, 4 months ago (2014-08-12 01:49:43 UTC) #4
Timothy Loh
TBRing pfeldman for devtools OWNERS, lushnikov has provided devtools lgtm.
6 years, 4 months ago (2014-08-12 01:49:56 UTC) #5
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 01:50:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/140001
6 years, 4 months ago (2014-08-12 01:51:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 03:02:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 04:10:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22171)
6 years, 4 months ago (2014-08-12 04:10:05 UTC) #10
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 04:10:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/140001
6 years, 4 months ago (2014-08-12 04:11:39 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 04:29:48 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 04:44:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22180)
6 years, 4 months ago (2014-08-12 04:44:10 UTC) #15
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 05:12:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/140001
6 years, 4 months ago (2014-08-12 05:13:50 UTC) #17
commit-bot: I haz the power
Change committed as 180034
6 years, 4 months ago (2014-08-12 06:17:39 UTC) #18
adamk
Reverted in https://src.chromium.org/viewvc/blink?revision=180090&view=revision for assertion failures in print preview browser_tests
6 years, 4 months ago (2014-08-12 18:17:48 UTC) #19
Timothy Loh
On 2014/08/12 18:17:48, adamk wrote: > Reverted in https://src.chromium.org/viewvc/blink?revision=180090&view=revision > for assertion failures in print ...
6 years, 4 months ago (2014-08-13 04:19:05 UTC) #20
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-13 04:21:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/160001
6 years, 4 months ago (2014-08-13 04:21:35 UTC) #22
alancutter (OOO until 2018)
lgtm to updated patch.
6 years, 4 months ago (2014-08-13 04:22:02 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 05:23:22 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 05:27:45 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7246)
6 years, 4 months ago (2014-08-13 05:27:47 UTC) #26
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-13 06:07:22 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/160001
6 years, 4 months ago (2014-08-13 06:08:08 UTC) #28
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 06:14:16 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 06:17:42 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7252)
6 years, 4 months ago (2014-08-13 06:17:43 UTC) #31
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-13 07:06:19 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/160001
6 years, 4 months ago (2014-08-13 07:07:15 UTC) #33
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 07:10:57 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 07:14:17 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7262)
6 years, 4 months ago (2014-08-13 07:14:18 UTC) #36
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-13 07:25:13 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/415613002/160001
6 years, 4 months ago (2014-08-13 07:26:19 UTC) #38
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 07:41:29 UTC) #39
Message was sent while issue was closed. 
Change committed as 180151

Powered by Google App Engine
This is Rietveld 408576698