Add IPC benchmarking API to Blink TestRunner

Add IPC benchmarking API to window behind --expose-ipc-echo

This add an window.ipcEcho API that sends do-nothing IPC 
message to measure RTT. The API is behind a flag, 
and will be used to build IPC benchmark using JavaScript.

TEST=none (Will add blink-side LayoutTest once this is landed)
BUG=402185
R=darin@chromium.org, jam@chromim.org, jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290063

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290715

[darin (slow to review), 2014-08-15 03:25:32]

LGTM

However, can you describe further how this will be used? I'm assuming you intend
to create a layout test to exercise this, and then vary the backing
implementation of the IPC::Channel. That all makes sense. However, will you be
checking in your test? Will it run on any bots? Maybe "yes" and "no" are the
answers? Does this even need to be checked in?

[Hajime Morrita, 2014-08-15 17:08:34]

On 2014/08/15 03:25:32, darin wrote:
> LGTM
> 
> However, can you describe further how this will be used? I'm assuming you
intend
> to create a layout test to exercise this, and then vary the backing
> implementation of the IPC::Channel. That all makes sense. However, will you be
> checking in your test? Will it run on any bots? Maybe "yes" and "no" are the
> answers? Does this even need to be checked in?

Yes, I'll use this to write HTML/JS based benchmark,
but I have no plan to check in the benchmark itself so far.
Making benchmark working as a LayoutTest is tricky.
It could be part of Telemetry suite though.

And no, I don't think the IPC benchmark should be part of bot coverage
as it would be just a microbenchmark and doesn't reflect any practical usage.

I'd like to check this in mainly because it allow us (not only me)
run the benchmark easily.

I see some latecny dropdown w/ IPC::ChannelMojo. Having this in the tree will
help us to address it.

Once IPC::ChannelMojo is settled, it totally makes sense to remove this from the
tree.
I'll add comment to mention that.

[darin (slow to review), 2014-08-15 17:33:54]

OK, sounds like a good plan. Thanks for the details.

-Darin


On Fri, Aug 15, 2014 at 10:08 AM, <morrita@chromium.org> wrote:

> On 2014/08/15 03:25:32, darin wrote:
>
>> LGTM
>>
>
>  However, can you describe further how this will be used? I'm assuming you
>>
> intend
>
>> to create a layout test to exercise this, and then vary the backing
>> implementation of the IPC::Channel. That all makes sense. However, will
>> you be
>> checking in your test? Will it run on any bots? Maybe "yes" and "no" are
>> the
>> answers? Does this even need to be checked in?
>>
>
> Yes, I'll use this to write HTML/JS based benchmark,
> but I have no plan to check in the benchmark itself so far.
> Making benchmark working as a LayoutTest is tricky.
> It could be part of Telemetry suite though.
>
> And no, I don't think the IPC benchmark should be part of bot coverage
> as it would be just a microbenchmark and doesn't reflect any practical
> usage.
>
> I'd like to check this in mainly because it allow us (not only me)
> run the benchmark easily.
>
> I see some latecny dropdown w/ IPC::ChannelMojo. Having this in the tree
> will
> help us to address it.
>
> Once IPC::ChannelMojo is settled, it totally makes sense to remove this
> from the
> tree.
> I'll add comment to mention that.
>
>
> https://codereview.chromium.org/478483005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Hajime Morrita, 2014-08-15 19:42:49]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2014-08-15 19:42:56]

The CQ bit was unchecked by morrita@chromium.org

[Hajime Morrita, 2014-08-15 19:45:50]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:51:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/478483005/40001

[commit-bot: I haz the power, 2014-08-16 00:20:01]

Committed patchset #3 (40001) as 290063

[sof, 2014-08-16 15:45:52]

https://codereview.chromium.org/478483005/diff/40001/content/shell/renderer/w...
File content/shell/renderer/webkit_test_runner.cc (right):

https://codereview.chromium.org/478483005/diff/40001/content/shell/renderer/w...
content/shell/renderer/webkit_test_runner.cc:577: DCHECK(ipc_echo_);
This is an unsound assumption. For code that traverses the properties hanging
off of "window" (include "window.testing") -- e.g., a test using
LayoutTests/fast/dom/Window/resources/window-property-collector.js, it might
touch lastEchoId without invoking requestEcho() first.

This is currently causing half a dozen assert crashes across the bots,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35621

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/...
 
Revert or address right away?

[sof, 2014-08-16 16:10:37]

Reverted via https://codereview.chromium.org/477343002/

[Hajime Morrita, 2014-08-18 22:34:43]

On 2014/08/16 16:10:37, sof wrote:
> Reverted via https://codereview.chromium.org/477343002/

... and turned out that on Android, running non-LayoutTest contents with
--dump-render-tree is too unreliable.
It crashes even with https://google.com/ or http://example.com/. 

I'll try some different path.

[Hajime Morrita, 2014-08-19 01:01:49]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2014-08-19 01:02:47]

The CQ bit was unchecked by morrita@chromium.org

[Hajime Morrita, 2014-08-19 01:13:43]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-08-19 01:15:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/478483005/100001

[commit-bot: I haz the power, 2014-08-19 02:00:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/48557)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-19 02:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 02:07:10]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)

[Hajime Morrita, 2014-08-19 17:10:46]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-08-19 17:11:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/478483005/120001

[Hajime Morrita, 2014-08-19 18:03:04]

The CQ bit was unchecked by morrita@chromium.org

[Hajime Morrita, 2014-08-19 20:38:41]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-08-19 20:39:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/478483005/140001

[commit-bot: I haz the power, 2014-08-19 23:20:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 00:32:05]

Committed patchset #8 (140001) as 290715