Add IPC benchmarking API to Blink TestRunner

content/shell/renderer/webkit_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/webkit_test_runner.h"
 
 #include <algorithm>
 #include <clocale>
 #include <cmath>
 
@@ skipping 12 matching lines @@
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/web_preferences.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/render_view_visitor.h"
 #include "content/public/test/layouttest_support.h"
 #include "content/shell/common/shell_messages.h"
 #include "content/shell/common/shell_switches.h"
 #include "content/shell/common/webkit_test_helpers.h"
 #include "content/shell/renderer/gc_controller.h"
+#include "content/shell/renderer/ipc_echo.h"
 #include "content/shell/renderer/leak_detector.h"
 #include "content/shell/renderer/shell_render_process_observer.h"
 #include "content/shell/renderer/test_runner/WebTask.h"
 #include "content/shell/renderer/test_runner/WebTestInterfaces.h"
 #include "content/shell/renderer/test_runner/mock_screen_orientation_client.h"
 #include "content/shell/renderer/test_runner/web_test_proxy.h"
 #include "content/shell/renderer/test_runner/web_test_runner.h"
 #include "net/base/filename_util.h"
 #include "net/base/net_errors.h"
 #include "skia/ext/platform_canvas.h"
@@ skipping 512 matching lines @@
   }
 
   if (id == routing_ids_.end()) {
     NOTREACHED();
     return std::string();
   }
   return DumpBackForwardList(session_histories_[pos],
                              current_entry_indexes_[pos]);
 }
 
+void WebKitTestRunner::requestEcho(int id, int size) {
+  if (!ipc_echo_) {
+    RenderView* view = render_view();
+    ipc_echo_.reset(new IPCEcho(view->GetWebView()->mainFrame()->document(),
+                                view, view->GetRoutingID()));
+  }
+
+  ipc_echo_->RequestEcho(id, size);
+}
+
+int WebKitTestRunner::lastEchoId() {
+  DCHECK(ipc_echo_);

[sof, 2014/08/16 15:45:52]

This is an unsound assumption. For code that traverses the properties hanging
off of "window" (include "window.testing") -- e.g., a test using
LayoutTests/fast/dom/Window/resources/window-property-collector.js, it might
touch lastEchoId without invoking requestEcho() first.

This is currently causing half a dozen assert crashes across the bots,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/35621

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/...
 
Revert or address right away?

+  return ipc_echo_->last_echo_id();
+}
+
+int WebKitTestRunner::lastEchoSize() {
+  DCHECK(ipc_echo_);
+  return ipc_echo_->last_echo_size();
+}
+
 // RenderViewObserver  --------------------------------------------------------
 
 void WebKitTestRunner::DidClearWindowObject(WebLocalFrame* frame) {
   WebTestingSupport::injectInternalsObject(frame);
   ShellRenderProcessObserver::GetInstance()->test_interfaces()->bindTo(frame);
   GCController::Install(frame);
 }
 
 bool WebKitTestRunner::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(WebKitTestRunner, message)
+    IPC_MESSAGE_HANDLER(ShellViewMsg_EchoPong, OnEchoPong)
     IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
                         OnSetTestConfiguration)
     IPC_MESSAGE_HANDLER(ShellViewMsg_SessionHistory, OnSessionHistory)
     IPC_MESSAGE_HANDLER(ShellViewMsg_Reset, OnReset)
     IPC_MESSAGE_HANDLER(ShellViewMsg_NotifyDone, OnNotifyDone)
     IPC_MESSAGE_HANDLER(ShellViewMsg_TryLeakDetection, OnTryLeakDetection)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
@@ skipping 99 matching lines @@
 void WebKitTestRunner::CaptureDumpComplete() {
   render_view()->GetWebView()->mainFrame()->stopLoading();
 
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(base::IgnoreResult(&WebKitTestRunner::Send),
                  base::Unretained(this),
                  new ShellViewHostMsg_TestFinished(routing_id())));
 }
 
+void WebKitTestRunner::OnEchoPong(int id, const std::string& body) {
+  ipc_echo_->DidRespondEcho(id, body.size());
+}
+
 void WebKitTestRunner::OnSetTestConfiguration(
     const ShellTestConfiguration& params) {
   test_config_ = params;
   is_main_window_ = true;
 
   ForceResizeRenderView(
       render_view(),
       WebSize(params.initial_size.width(), params.initial_size.height()));
   setFocus(proxy_, true);
 
@@ skipping 37 matching lines @@
 
   leak_detector_->TryLeakDetection(main_frame);
 }
 
 void WebKitTestRunner::ReportLeakDetectionResult(
     const LeakDetectionResult& report) {
   Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report));
 }
 
 }  // namespace content