Source/core/svg/animation/SMILTime.cpp - Issue 478273002: Use NaN/Inf to represent unresolved/indefinite SMILTimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SMILTime.cpp

Issue 478273002: Use NaN/Inf to represent unresolved/indefinite SMILTimes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix regression. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/svg/animation/SMILTime.h ('K') | « Source/core/svg/animation/SMILTime.h ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/animation/SMILTime.cpp

diff --git a/Source/core/svg/animation/SMILTime.cpp b/Source/core/svg/animation/SMILTime.cpp

index d83230e963ba236a2d23d7529cafcefee6563c04..7abef296001dca9191d29faf4697b6411346878d 100644

--- a/Source/core/svg/animation/SMILTime.cpp

+++ b/Source/core/svg/animation/SMILTime.cpp

@@ -31,10 +31,6 @@

using namespace blink;

-const double SMILTime::unresolvedValue = DBL_MAX;

-// Just a big value smaller than DBL_MAX. Our times are relative to 0, we don't really need the full range.

-const double SMILTime::indefiniteValue = FLT_MAX;

SMILTime blink::operator+(const SMILTime& a, const SMILTime& b)

{

if (a.isUnresolved() || b.isUnresolved())

fs 2014/08/19 21:49:43 Note: With this new representation, this should no