LayoutTests/css3/flexbox/flex-longhand-parsing.html - Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/css3/flexbox/flex-longhand-parsing.html

Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/calc/number-parsing.html ('k') | LayoutTests/css3/flexbox/flex-longhand-parsing-expected.txt » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/css3/flexbox/flex-longhand-parsing.html

diff --git a/LayoutTests/css3/flexbox/flex-longhand-parsing.html b/LayoutTests/css3/flexbox/flex-longhand-parsing.html

index ce583b770aad9aec5375658bba0416e4d6acc91a..4a9a4d13b173375a2093d5347f63cbc188b8e7aa 100644

--- a/LayoutTests/css3/flexbox/flex-longhand-parsing.html

+++ b/LayoutTests/css3/flexbox/flex-longhand-parsing.html

@@ -56,11 +56,11 @@ shouldBeEqualToString('flexitem.style.webkitFlex', '1.5 0 auto');

shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.5 0 auto');

flexitem.style.webkitFlex = 3;

-shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 0%');

shouldBeEqualToString('flexitem.style.webkitFlexGrow', '3');

shouldBeEqualToString('flexitem.style.webkitFlexShrink', '1');

-shouldBeEqualToString('flexitem.style.webkitFlexBasis', '0px');

-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 0px');

+shouldBeEqualToString('flexitem.style.webkitFlexBasis', '0%');

+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 0%');

</script>

</body>