LayoutTests/css3/calc/number-parsing.html - Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/css3/calc/number-parsing.html

Issue 478233004: Flexbox flex: 1 incorrectly sets flex-basis to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/css3/calc/number-parsing.html

diff --git a/LayoutTests/css3/calc/number-parsing.html b/LayoutTests/css3/calc/number-parsing.html

index e89c8acd55bdb166587a9c84e6be8d2609893474..bf70d62c3549107230eb5bd6ba810c71f0da4fc6 100644

--- a/LayoutTests/css3/calc/number-parsing.html

+++ b/LayoutTests/css3/calc/number-parsing.html

@@ -20,7 +20,7 @@ test(function() {

assertParsedValue('grid-row-start', 'calc(1 + 2) test', '3 test');

assertParsedValue('grid-row-start', 'calc(1 / 2) test', null);

assertParsedValue('font-weight', 'calc(100 + 200)', null);

- assertParsedValue('flex', 'calc(1 + 2) calc(3 + 4)', '3 7 0px');

+ assertParsedValue('flex', 'calc(1 + 2) calc(3 + 4)', '3 7 0%');

assertParsedValue('-webkit-aspect-ratio', 'calc(1 + 2)/calc(3 + 4)', '3/7');

assertParsedValue('-webkit-filter', 'saturate(calc(4 / 2))', 'saturate(2)');

assertParsedValue('-webkit-filter', 'invert(calc(4 / 2))', null);

« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-longhand-parsing.html » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')