printing/page_number.cc - Issue 47823002: De-duplicate job_settings parsing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/page_number.cc

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Noam's comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/page_number.cc

diff --git a/printing/page_number.cc b/printing/page_number.cc

index 8e9287027e7159853148884b0e31a438c397cd3f..db3861dbdffd453d2b10b4494e917a60e3babbb1 100644

--- a/printing/page_number.cc

+++ b/printing/page_number.cc

@@ -31,7 +31,7 @@ void PageNumber::operator=(const PageNumber& other) {

void PageNumber::Init(const PrintSettings& settings, int document_page_count) {

DCHECK(document_page_count);

- ranges_ = settings.ranges.empty() ? NULL : &settings.ranges;

+ ranges_ = settings.ranges().empty() ? NULL : &settings.ranges();

document_page_count_ = document_page_count;

if (ranges_) {

page_range_index_ = 0;