Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6358)

Unified Diff: chrome/browser/printing/printing_message_filter.cc

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Noam's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job_worker.cc ('k') | printing/page_number.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/printing_message_filter.cc
diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc
index abd6b104e4319ed89107feba897542bf85c17b06..262ed799feb22f85d27d0739aa623e8ffab3b1a2 100644
--- a/chrome/browser/printing/printing_message_filter.cc
+++ b/chrome/browser/printing/printing_message_filter.cc
@@ -71,19 +71,19 @@ void RenderParamsFromPrintSettings(const printing::PrintSettings& settings,
params->margin_left = settings.page_setup_device_units().content_area().x();
params->dpi = settings.dpi();
// Currently hardcoded at 1.25. See PrintSettings' constructor.
- params->min_shrink = settings.min_shrink;
+ params->min_shrink = settings.min_shrink();
// Currently hardcoded at 2.0. See PrintSettings' constructor.
- params->max_shrink = settings.max_shrink;
+ params->max_shrink = settings.max_shrink();
// Currently hardcoded at 72dpi. See PrintSettings' constructor.
- params->desired_dpi = settings.desired_dpi;
+ params->desired_dpi = settings.desired_dpi();
// Always use an invalid cookie.
params->document_cookie = 0;
- params->selection_only = settings.selection_only;
+ params->selection_only = settings.selection_only();
params->supports_alpha_blend = settings.supports_alpha_blend();
- params->should_print_backgrounds = settings.should_print_backgrounds;
- params->display_header_footer = settings.display_header_footer;
- params->title = settings.title;
- params->url = settings.url;
+ params->should_print_backgrounds = settings.should_print_backgrounds();
+ params->display_header_footer = settings.display_header_footer();
+ params->title = settings.title();
+ params->url = settings.url();
}
} // namespace
@@ -393,7 +393,7 @@ void PrintingMessageFilter::OnScriptedPrintReply(
RenderParamsFromPrintSettings(printer_query->settings(), &params.params);
params.params.document_cookie = printer_query->cookie();
params.pages =
- printing::PageRange::GetPages(printer_query->settings().ranges);
+ printing::PageRange::GetPages(printer_query->settings().ranges());
}
PrintHostMsg_ScriptedPrint::WriteReplyParams(reply_msg, params);
Send(reply_msg);
@@ -455,7 +455,7 @@ void PrintingMessageFilter::OnUpdatePrintSettingsReply(
RenderParamsFromPrintSettings(printer_query->settings(), &params.params);
params.params.document_cookie = printer_query->cookie();
params.pages =
- printing::PageRange::GetPages(printer_query->settings().ranges);
+ printing::PageRange::GetPages(printer_query->settings().ranges());
}
PrintHostMsg_UpdatePrintSettings::WriteReplyParams(reply_msg, params);
Send(reply_msg);
« no previous file with comments | « chrome/browser/printing/print_job_worker.cc ('k') | printing/page_number.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698