Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: printing/print_settings_initializer.h

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« printing/print_settings.h ('K') | « printing/print_settings.cc ('k') | printing/print_settings_initializer.cc » ('j') | printing/print_settings_initializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/print_settings_initializer.h
diff --git a/printing/print_settings_initializer.h b/printing/print_settings_initializer.h
index 4897be87e186bf2bb8c0fd1d05a70be67ba4e7ba..a1093c5a3b8609a93a147329912a525e5f7194ba 100644
--- a/printing/print_settings_initializer.h
+++ b/printing/print_settings_initializer.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/logging.h"
+#include "printing/page_range.h"
Lei Zhang 2013/10/28 23:40:23 You can just forward declare instead.
Vitaly Buka (NO REVIEWS) 2013/10/29 00:36:00 Only PageRange. PageRanges is "typedef vector<>"
#include "printing/printing_export.h"
namespace base {
@@ -21,8 +22,9 @@ class PrintSettings;
// provided |job_settings|.
class PRINTING_EXPORT PrintSettingsInitializer {
public:
- static void InitHeaderFooterStrings(
+ static bool InitSettings(
const base::DictionaryValue& job_settings,
+ const PageRanges& ranges,
PrintSettings* print_settings);
private:
« printing/print_settings.h ('K') | « printing/print_settings.cc ('k') | printing/print_settings_initializer.cc » ('j') | printing/print_settings_initializer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698