De-duplicate job_settings parsing code.

printing/print_settings_initializer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_PRINT_SETTINGS_INITIALIZER_H_
 #define PRINTING_PRINT_SETTINGS_INITIALIZER_H_
 
 #include "base/basictypes.h"
 #include "base/logging.h"
+#include "printing/page_range.h"

[Lei Zhang, 2013/10/28 23:40:23]

You can just forward declare instead.

[Vitaly Buka (NO REVIEWS), 2013/10/29 00:36:00]

Only PageRange. PageRanges is "typedef vector<>"

 #include "printing/printing_export.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace printing {
 
 class PrintSettings;
 
 // Initializes the header footer strings in the PrintSettings object from the
 // provided |job_settings|.
 class PRINTING_EXPORT PrintSettingsInitializer {
  public:
-  static void InitHeaderFooterStrings(
+  static bool InitSettings(
       const base::DictionaryValue& job_settings,
+      const PageRanges& ranges,
       PrintSettings* print_settings);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PrintSettingsInitializer);
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_PRINT_SETTINGS_INITIALIZER_H_