Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6759)

Unified Diff: chrome/browser/printing/printing_message_filter.cc

Issue 478183005: Added PrintingContext::Delegate to get parent view handle and application locale. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mon Aug 25 23:50:54 PDT 2014 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/printing_message_filter.cc
diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc
index 37c5984dab0db7c4f888126f9d14d1bb6499a3d7..14657d793ac3199e230feb0f2dda71f0e99365aa 100644
--- a/chrome/browser/printing/printing_message_filter.cc
+++ b/chrome/browser/printing/printing_message_filter.cc
@@ -17,6 +17,7 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/child_process_host.h"
#if defined(ENABLE_FULL_PRINTING)
#include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
@@ -258,49 +259,6 @@ content::WebContents* PrintingMessageFilter::GetWebContentsForRenderView(
return view ? content::WebContents::FromRenderViewHost(view) : NULL;
}
-struct PrintingMessageFilter::GetPrintSettingsForRenderViewParams {
- PrinterQuery::GetSettingsAskParam ask_user_for_settings;
- int expected_page_count;
- bool has_selection;
- MarginType margin_type;
-};
-
-void PrintingMessageFilter::GetPrintSettingsForRenderView(
- int render_view_id,
- GetPrintSettingsForRenderViewParams params,
- const base::Closure& callback,
- scoped_refptr<PrinterQuery> printer_query) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- content::WebContents* wc = GetWebContentsForRenderView(render_view_id);
- if (wc) {
- scoped_ptr<PrintingUIWebContentsObserver> wc_observer(
- new PrintingUIWebContentsObserver(wc));
- BrowserThread::PostTask(BrowserThread::IO,
- FROM_HERE,
- base::Bind(&PrinterQuery::GetSettings,
- printer_query,
- params.ask_user_for_settings,
- base::Passed(&wc_observer),
- params.expected_page_count,
- params.has_selection,
- params.margin_type,
- callback));
- } else {
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- base::Bind(&PrintingMessageFilter::OnGetPrintSettingsFailed, this,
- callback, printer_query));
- }
-}
-
-void PrintingMessageFilter::OnGetPrintSettingsFailed(
- const base::Closure& callback,
- scoped_refptr<PrinterQuery> printer_query) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- printer_query->GetSettingsDone(PrintSettings(), PrintingContext::FAILED);
- callback.Run();
-}
-
void PrintingMessageFilter::OnIsPrintingEnabled(bool* is_enabled) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
*is_enabled = profile_io_data_->printing_enabled()->GetValue();
@@ -315,23 +273,22 @@ void PrintingMessageFilter::OnGetDefaultPrintSettings(IPC::Message* reply_msg) {
return;
}
printer_query = queue_->PopPrinterQuery(0);
- if (!printer_query)
- printer_query = queue_->CreatePrinterQuery();
+ if (!printer_query) {
+ printer_query =
+ queue_->CreatePrinterQuery(render_process_id_, reply_msg->routing_id());
+ }
// Loads default settings. This is asynchronous, only the IPC message sender
// will hang until the settings are retrieved.
- GetPrintSettingsForRenderViewParams params;
- params.ask_user_for_settings = PrinterQuery::DEFAULTS;
- params.expected_page_count = 0;
- params.has_selection = false;
- params.margin_type = DEFAULT_MARGINS;
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&PrintingMessageFilter::GetPrintSettingsForRenderView, this,
- reply_msg->routing_id(), params,
- base::Bind(&PrintingMessageFilter::OnGetDefaultPrintSettingsReply,
- this, printer_query, reply_msg),
- printer_query));
+ printer_query->GetSettings(
+ PrinterQuery::DEFAULTS,
+ 0,
+ false,
+ DEFAULT_MARGINS,
+ base::Bind(&PrintingMessageFilter::OnGetDefaultPrintSettingsReply,
+ this,
+ printer_query,
+ reply_msg));
}
void PrintingMessageFilter::OnGetDefaultPrintSettingsReply(
@@ -363,21 +320,19 @@ void PrintingMessageFilter::OnScriptedPrint(
IPC::Message* reply_msg) {
scoped_refptr<PrinterQuery> printer_query =
queue_->PopPrinterQuery(params.cookie);
- if (!printer_query)
- printer_query = queue_->CreatePrinterQuery();
- GetPrintSettingsForRenderViewParams settings_params;
- settings_params.ask_user_for_settings = PrinterQuery::ASK_USER;
- settings_params.expected_page_count = params.expected_pages_count;
- settings_params.has_selection = params.has_selection;
- settings_params.margin_type = params.margin_type;
-
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&PrintingMessageFilter::GetPrintSettingsForRenderView, this,
- reply_msg->routing_id(), settings_params,
- base::Bind(&PrintingMessageFilter::OnScriptedPrintReply, this,
- printer_query, reply_msg),
- printer_query));
+ if (!printer_query) {
+ printer_query =
+ queue_->CreatePrinterQuery(render_process_id_, reply_msg->routing_id());
+ }
+ printer_query->GetSettings(
+ PrinterQuery::ASK_USER,
+ params.expected_pages_count,
+ params.has_selection,
+ params.margin_type,
+ base::Bind(&PrintingMessageFilter::OnScriptedPrintReply,
+ this,
+ printer_query,
+ reply_msg));
}
void PrintingMessageFilter::OnScriptedPrintReply(
@@ -440,8 +395,18 @@ void PrintingMessageFilter::OnUpdatePrintSettings(
return;
}
printer_query = queue_->PopPrinterQuery(document_cookie);
- if (!printer_query)
- printer_query = queue_->CreatePrinterQuery();
+ if (!printer_query) {
+ int host_id = render_process_id_;
+ int routing_id = reply_msg->routing_id();
+ if (!new_settings->GetInteger(printing::kPreviewInitiatorHostId,
+ &host_id) ||
+ !new_settings->GetInteger(printing::kPreviewInitiatorRoutingId,
+ &routing_id)) {
+ host_id = content::ChildProcessHost::kInvalidUniqueID;
+ routing_id = content::ChildProcessHost::kInvalidUniqueID;
+ }
+ printer_query = queue_->CreatePrinterQuery(host_id, routing_id);
+ }
printer_query->SetSettings(
new_settings.Pass(),
base::Bind(&PrintingMessageFilter::OnUpdatePrintSettingsReply, this,
« no previous file with comments | « chrome/browser/printing/printing_message_filter.h ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698