Issue 478183002: Add a null check before getting unicode text in CPDF_FormField::GetValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 478183002: Add a null check before getting unicode text in CPDF_FormField::GetValue (Closed)

Created:
6 years, 4 months ago by jun_fang

Modified:
5 years, 9 months ago

Reviewers:
Tom Sepez, Bo Xu

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Add a null check before getting unicode text in CPDF_FormField::GetValue The test pdf file defines an invalid dictionary object with a NULL arrary in the filed of "/V". It causes that a NULL object is returned when trying to get the first element of this arrary. So it needs to check whether the returned object is NULL. BUG=395986 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/91177a4

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	core/src/fpdfdoc/doc_formfield.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jun_fang

6 years, 4 months ago (2014-08-18 18:31:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 91177a4 (presubmit successful).

Expand Messages | Collapse Messages