core/src/fpdfdoc/doc_formfield.cpp - Issue 478183002: Add a null check before getting unicode text in CPDF_FormField::GetValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_formfield.cpp

Issue 478183002: Add a null check before getting unicode text in CPDF_FormField::GetValue (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfdoc/doc_formfield.cpp

diff --git a/core/src/fpdfdoc/doc_formfield.cpp b/core/src/fpdfdoc/doc_formfield.cpp

index eeba372390e348b928682674ef36286ff3b9ae34..a2f0fbd297e5f7f8c68824021238c8a1503ae2ef 100644

--- a/core/src/fpdfdoc/doc_formfield.cpp

+++ b/core/src/fpdfdoc/doc_formfield.cpp

@@ -324,7 +324,9 @@ CFX_WideString CPDF_FormField::GetValue(FX_BOOL bDefault)

return pValue->GetUnicodeText();

case PDFOBJ_ARRAY:

pValue = ((CPDF_Array*)pValue)->GetElementValue(0);

- return pValue->GetUnicodeText();

+ if (pValue) {

+ return pValue->GetUnicodeText();

+ }

break;

}

return CFX_WideString();

« no previous file with comments | « no previous file | no next file » | no next file with comments »