Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: content/browser/appcache/mock_appcache_storage_unittest.cc

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_update_job_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/mock_appcache_storage_unittest.cc
diff --git a/content/browser/appcache/mock_appcache_storage_unittest.cc b/content/browser/appcache/mock_appcache_storage_unittest.cc
index c41fe53028020e7697a15aca506f873f1886e37d..a945b271af070ed82917a2b2bf4b461670b6f964 100644
--- a/content/browser/appcache/mock_appcache_storage_unittest.cc
+++ b/content/browser/appcache/mock_appcache_storage_unittest.cc
@@ -237,7 +237,7 @@ TEST_F(MockAppCacheStorageTest, StoreNewGroup) {
EXPECT_TRUE(delegate.stored_group_success_);
EXPECT_FALSE(storage->stored_caches_.empty());
EXPECT_FALSE(storage->stored_groups_.empty());
- EXPECT_EQ(cache, group->newest_complete_cache());
+ EXPECT_EQ(cache.get(), group->newest_complete_cache());
EXPECT_TRUE(cache->is_complete());
}
@@ -306,7 +306,7 @@ TEST_F(MockAppCacheStorageTest, StoreExistingGroupExistingCache) {
// Hold our refs to simulate the UpdateJob holding these refs.
// Change the group's newest cache.
- EXPECT_EQ(cache, group->newest_complete_cache());
+ EXPECT_EQ(cache.get(), group->newest_complete_cache());
GURL entry_url("http://blah/blah");
cache->AddEntry(entry_url, AppCacheEntry(AppCacheEntry::MASTER));
@@ -324,7 +324,7 @@ TEST_F(MockAppCacheStorageTest, StoreExistingGroupExistingCache) {
EXPECT_EQ(size_t(1), storage->stored_caches_.size());
EXPECT_EQ(size_t(1), storage->stored_groups_.size());
EXPECT_TRUE(storage->IsCacheStored(cache.get()));
- EXPECT_EQ(cache, group->newest_complete_cache());
+ EXPECT_EQ(cache.get(), group->newest_complete_cache());
EXPECT_TRUE(cache->GetEntry(entry_url));
}
« no previous file with comments | « content/browser/appcache/appcache_update_job_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698