Fill in descriptions on relevant blink_perf tests

Fill in descriptions on relevant blink_perf tests

The new descriptions make it easier to quickly determine what each test is
doing. There should be no performance impact on the tests themselves as
setting the description is not in the critical section of the tests.

BUG=404274
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184155

[Daniel Imms, 2014-08-15 22:36:25]

Reviewers, please suggest other reviewers as necessary. Thanks :)

Also note I'm not currently in the AUTHORS file but I should be on the CCLA.

[tonyg, 2014-10-06 19:42:14]

lgtm modulo a couple of nits.

Thanks for doing this, it's really helpful. I believe Quinten is also working on
getting all of these displayed on the perf dashboard.

ps. Sorry for the delay, this somehow missed my attention. In the future, please
ping earlier.

https://codereview.chromium.org/478003002/diff/1/PerformanceTests/Bindings/gc...
File PerformanceTests/Bindings/gc-mini-tree.html (right):

https://codereview.chromium.org/478003002/diff/1/PerformanceTests/Bindings/gc...
PerformanceTests/Bindings/gc-mini-tree.html:6: description: "Measures
performance of creating one million divs that contain spans without retaining
references, then running the garbage collector.",
s/one million/a half million/

https://codereview.chromium.org/478003002/diff/1/PerformanceTests/Layout/hind...
File PerformanceTests/Layout/hindi-line-layout.html (right):

https://codereview.chromium.org/478003002/diff/1/PerformanceTests/Layout/hind...
PerformanceTests/Layout/hindi-line-layout.html:18: <p lang="hi" xml:lang="hi"
title="This is Hindi"><span id="e8" class="ex">हालाँकि</span> सूर के जीवन के
बारे में कई जनश्रुतियाँ <span id="e9" class="ex">प्रचलित</span> <span id="e3"
class="ex">हैं</span>, पर इन में कितनी सच्चाई है यह कहना कठिन है। कहा जाता है
उनका जन्म सन् <span id="e10" class="ex">१४७८</span> में <span id="e4"
class="ex">दिल्ली</span> के पास एक ग़रीब ब्राह्मीण परिवार <span id="e1"
class="ex">में</span> हुआ। जनश्रुति के अनुसार सूरदास जन्म से ही अंधे थे। आजकल थी
<span id="e2" class="ex">अंधे</span> आदमी अक्सर 'सूरदास' कहलाते हैं। कई लो���ों
ने उन्हें गुरु के <span id="e6" class="ex">रूप</span> में अपनाया और उनकी <span
id="e7" class="ex">पूजा</span> करना शुरु कर दिया । </p>
Stray diff?

[Daniel Imms, 2014-10-07 22:19:13]

Thanks for the review Tony. I don't believe I'm in the AUTHORS file yet, can you
add me and submit this to the commit queue please?

[rjwright, 2014-10-13 02:17:33]

On 2014/10/07 22:19:13, daniimms wrote:
> Thanks for the review Tony. I don't believe I'm in the AUTHORS file yet, can
you
> add me and submit this to the commit queue please?

Hi Dan. I'm looking at this now. I don't think I'll get through it all in one
hit - it's a bit scary.

Where did these descriptions come from? Did you write them from scratch by
reading the tests (in which case I salute you) or did you pull the descriptions
from the CLs in which the tests were originally added?

[Daniel Imms, 2014-10-13 14:13:25]

On 2014/10/13 02:17:33, rjwright wrote:
> On 2014/10/07 22:19:13, daniimms wrote:
> > Thanks for the review Tony. I don't believe I'm in the AUTHORS file yet, can
> you
> > add me and submit this to the commit queue please?
> 
> Hi Dan. I'm looking at this now. I don't think I'll get through it all in one
> hit - it's a bit scary.
> 
> Where did these descriptions come from? Did you write them from scratch by
> reading the tests (in which case I salute you) or did you pull the
descriptions
> from the CLs in which the tests were originally added?

Hi Renee, I wrote them from scratch by examining the code.

[rjwright, 2014-10-15 03:37:13]

I've only reviewed the animations ones, because they're the only ones I know
anything about.

I've made a fair few comments. Most of them are in the interest of being clear
about which API is being tested.

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/api-balls-keyframe-animations.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/api-balls-keyframe-animations.html:75: description:
'Measures performance of CSS keyframes animation using the web animations API
(animating on left and top).',
These aren't actually CSS keyframes. Web Animations keyframes are just JS dicts.
Obviously they get turned into CSS style declarations, but I think a better
description would be something like

"Measure performance of Web Animations API animating 'left' and 'top' using
Element.animate()"

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File
PerformanceTests/Animation/api-set-current-time-balls-keyframe-animations.html
(right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/api-set-current-time-balls-keyframe-animations.html:75:
description: 'Measures performance of CSS keyframes animation using the web
animations API and requestAnimationFrame (animating on left and top).',
This test is a bit weird. It creates an animation and immediately pauses it,
then advances the animation by setting its current time inside a RAF call. I'd
describe it as


"Measure performance of animating 'left' and 'top' by calling Element.animate()
(from the Web Animations API), pausing the player, and updating the player's
startTime using requestAnimationFrame."

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-composited-transform.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-composited-transform.html:74: description:
'Measures performance of CSS keyframes animation (animating on translate).',
"Measure performance of CSS Animations animating 'transform: translate'."

In this case the property being animated is important, and we should avoid
creating confusion about which API is being used.

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-javascript.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-javascript.html:75: description: 'Measures
animation performance of javascript to manipulate DOM elements (animating on
left and top).',
Maybe this would be better described as

"Measure performance of animating 'left' and 'top' by updating inline styles in
requestAnimationFrame"

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-keyframe-animations.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-keyframe-animations.html:74: description:
'Measures performance of CSS keyframes animation (animating on left and top).',
"Measure performance of CSS Animations animating 'left' and 'top'."

Again to avoid confusion about which API is being tested.

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transition-10-properties.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transition-10-properties.html:74: description:
'Measures performance of CSS transition animation (animating on left and top,
transition-property: [10 properties]).',
This confused me, but I am not very familiar with the transitions API.

Maybe say

"Measures performance of CSS Transitions, with a transition on 10 properties but
only 'left' and 'top' changing."

Or

"Measures performance of CSS Transitions animating 'left' and 'top' with
transition-property: [10 properties]."

Or similar. Up to you.

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transition-20-properties.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transition-20-properties.html:74: description:
'Measures performance of CSS transition animation (animating on left and top,
transition-property: [20 properties]).',
See comment on balls-transition-10-properties.html

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transition-40-properties.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transition-40-properties.html:75: done:
onCompletedRun,
As balls-transition-10-properties.html

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transition-all.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transition-all.html:74: description: 'Measures
performance of CSS transition animation (animating on left and top,
transition-property: all).',
balls-transition-10-properties.html

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transitions.html (right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transitions.html:74: description: 'Measures
performance of CSS transition animation (animating on left and top).',
"Measure performance of CSS Transitions animating 'left' and 'top' with
transition-property: 'left, top'."

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
File PerformanceTests/Animation/overlay-background-color-transitions.html
(right):

https://codereview.chromium.org/478003002/diff/20001/PerformanceTests/Animati...
PerformanceTests/Animation/overlay-background-color-transitions.html:72:
description: 'Measures performance of CSS transition animation with one
foreground animation and many in the background (animating on
background-color).',
"Measure performance of CSS Transitions animating background-color on many
overlaid elements (only one element showing)."

[rjwright, 2014-10-20 00:03:04]

On 2014/10/16 21:51:12, Daniel imms wrote:

LGTM.

I will get Alan Cutter to have a quick look at the new changes, since I
basically rewrote some of them.

Thanks for doing this!

[rjwright, 2014-10-20 00:03:42]

rjwright@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2014-10-20 00:09:34]

lgtm with nits.

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
File PerformanceTests/Animation/api-balls-keyframe-animations.html (right):

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
PerformanceTests/Animation/api-balls-keyframe-animations.html:75: description:
"Measure performance of Web Animations API animating 'left' and 'top'
usingElement.animate()",
Missing space before "using" and "Element".

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
File
PerformanceTests/Animation/api-set-current-time-balls-keyframe-animations.html
(right):

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
PerformanceTests/Animation/api-set-current-time-balls-keyframe-animations.html:75:
description: "Measure performance of animating 'left' and 'top' by calling
Element.animate() (from the Web Animations API), pausing the player, and
updating the player's startTime using requestAnimationFrame.",
s/startTime/currentTime/

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
File PerformanceTests/Animation/balls-transitions.html (right):

https://codereview.chromium.org/478003002/diff/60001/PerformanceTests/Animati...
PerformanceTests/Animation/balls-transitions.html:74: description: "Measure
performance of CSS Transitions animating 'left' and 'top' with
transition-property: 'left, top'.",
"transition-property: left, top" shouldn't have single quotes.

[Daniel Imms, 2014-10-20 23:55:39]

Thanks all, could someone push this to the commit queue?

[rjwright, 2014-10-22 06:09:14]

The CQ bit was checked by rjwright@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:09:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/478003002/80001

[commit-bot: I haz the power, 2014-10-22 08:51:42]

Committed patchset #4 (id:80001) as 184155