Make the WebView apk build in the Chrome tree

Make the WebView apk build in the Chrome tree
    
We checkout the Android WebView glue layer (frameworks/webview)
into a new third_party directory (android_webview_glue)
which is checked out via gclient.
   
This is built against a jar containing frameworks/base
(in android_platform/webview/frameworks.jar).
    
We have to work around a few other issues:
    - Change build/java_apk.gypi to bypass the hardcoded
      'src' path.
    - Move libwebviewchromium to an include so we can make both
      the prefixed and un-prefixed version in the same build.


BUG=391488
R=mkosiba@chromium.org

Committed: https://crrev.com/aefb27936dcf9694777440b8a2752b3c12300520
Cr-Commit-Position: refs/heads/master@{#293921}

[mkosiba (inactive), 2014-08-19 09:26:17]

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
File android_webview/android_webview_glue.gypi (right):

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:7: 'target_name':
'the_real_android_webview_apk',
maybe system_webview_apk?

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:22: 'package_name':
'com.android.webview.chromium', # ???
#???
I don't know either :) Maybe ask cmp@?

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:29:
'<(PRODUCT_DIR)/android_webview_assets/en-US.pak',
we'll want a better solution for these than including them case-by-case. File a
bug + TODO since we don't need all of the locale .pak files for the telemetry
bot.

[hjd, 2014-08-19 14:34:22]

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
File android_webview/android_webview_glue.gypi (right):

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:7: 'target_name':
'the_real_android_webview_apk',
On 2014/08/19 09:26:17, mkosiba wrote:
> maybe system_webview_apk?

Done.

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:22: 'package_name':
'com.android.webview.chromium', # ???
On 2014/08/19 09:26:17, mkosiba wrote:
> #???
> I don't know either :) Maybe ask cmp@?

I think I worked out what happened, package_name used to be how
you specified the intermediate directory, this one use of it
in java_apk seems to be left over from the refactoring.
I've uploaded a cl to remove it but for now I'll just change
this one to something more sane and update whichever patch lands
second.

https://codereview.chromium.org/477903003/diff/1/android_webview/android_webv...
android_webview/android_webview_glue.gypi:29:
'<(PRODUCT_DIR)/android_webview_assets/en-US.pak',
On 2014/08/19 09:26:17, mkosiba wrote:
> we'll want a better solution for these than including them case-by-case. File
a
> bug + TODO since we don't need all of the locale .pak files for the telemetry
> bot.

Done.

[mkosiba (inactive), 2014-08-20 10:51:19]

+torne for one more look over the gyp stuff
LGTM

https://codereview.chromium.org/477903003/diff/40001/android_webview/android_...
File android_webview/android_webview_glue.gypi (right):

https://codereview.chromium.org/477903003/diff/40001/android_webview/android_...
android_webview/android_webview_glue.gypi:27: # TODO: Find a better solution for
WebView .pak files.
add the bug number please

[Torne, 2014-08-21 17:18:50]

lgtm

[hjd, 2014-08-22 10:16:48]

The CQ bit was checked by hjd@chromium.org

[commit-bot: I haz the power, 2014-08-22 10:21:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hjd@chromium.org/477903003/100001

[commit-bot: I haz the power, 2014-08-22 11:19:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-22 11:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 11:20:43]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hjd, 2014-08-22 11:27:25]

The CQ bit was checked by hjd@chromium.org

[commit-bot: I haz the power, 2014-08-22 11:28:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hjd@chromium.org/477903003/120001

[commit-bot: I haz the power, 2014-08-22 11:38:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45142)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50326)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 11:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 11:40:28]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hjd, 2014-08-22 12:30:17]

The CQ bit was checked by hjd@chromium.org

[commit-bot: I haz the power, 2014-08-22 12:31:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hjd@chromium.org/477903003/140001

[commit-bot: I haz the power, 2014-08-22 13:30:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-22 13:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 13:34:42]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[hjd, 2014-09-01 13:16:38]

hjd@chromium.org changed reviewers:
+ open-source-third-party-reviews@google.com, security@chromium.org

[hjd, 2014-09-01 13:16:39]

ptal, I'm trying to add a new third_party DEPS
which checks out some AOSP Android code to make
it possible to build a version of the WebView
without an Android checkout.

open-source-third-party-reviews@
The code is from frameworks/webview in Android AOSP
which has a few contributions from non-googlers
(Intel and Chromium are the only examples I can see).

security@
I don't believe this to is a security risk;
this copy of the glue layer would never be shipped
in a build, the actual shipping WebView would
continue to be built in the Android tree (using the
internal version of the the glue layer).

Instead this code would be used locally by developers
to make it easier to test changes to the WebView
(by letting them build outside the Android tree) 
and by performance bots on the waterfall.

Thanks!

[Torne, 2014-09-02 10:34:08]

lgtm

https://codereview.chromium.org/477903003/diff/180001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/477903003/diff/180001/.gitignore#newcode46
.gitignore:46: /android_webview/glue
This entry is outdated I think?

[hjd, 2014-09-03 15:41:12]

https://codereview.chromium.org/477903003/diff/180001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/477903003/diff/180001/.gitignore#newcode46
.gitignore:46: /android_webview/glue
On 2014/09/02 10:34:07, Torne wrote:
> This entry is outdated I think?

Done, thanks.

[mkosiba (inactive), 2014-09-03 16:08:22]

LGTM.

[palmer, 2014-09-04 18:39:17]

LGTM from security perspective.

[Daniel Berlin, 2014-09-04 18:43:04]

dannyb@google.com changed reviewers:
+ dannyb@google.com

[Daniel Berlin, 2014-09-04 18:43:05]

lgtm

[hjd, 2014-09-09 09:47:09]

The CQ bit was checked by hjd@chromium.org

[commit-bot: I haz the power, 2014-09-09 09:47:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hjd@chromium.org/477903003/240001

[commit-bot: I haz the power, 2014-09-09 11:44:45]

Committed patchset #13 (id:240001) as 27d2bfd20b960093d5e5f92fc0aa44a9f805761f

[commit-bot: I haz the power, 2014-09-10 03:52:50]

Patchset 13 (id:??) landed as
https://crrev.com/aefb27936dcf9694777440b8a2752b3c12300520
Cr-Commit-Position: refs/heads/master@{#293921}