Make the WebView apk build in the Chrome tree

android_webview/android_webview_glue.gypi

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'targets': [
+    {
+      'target_name': 'the_real_android_webview_apk',

[mkosiba (inactive), 2014/08/19 09:26:17]

maybe system_webview_apk?

[hjd, 2014/08/19 14:34:22]

Done.

+      'type': 'none',
+      'dependencies': [
+        'libwebviewchromium',
+        'android_webview_java',
+        'android_webview_pak',
+      ],
+      'variables': {
+        'android_sdk_jar': '../third_party/android_platform/webview/frameworks.jar',
+        'apk_name': 'TheRealAndroidWebView',
+        'java_in_dir': '../android_webview/glue/chromium',
+        'java_in_dir_suffix': '/java',
+        'native_lib_target': 'libwebviewchromium',
+        'never_lint': 1,
+        'resource_dir': 'glue/chromium/res',
+        'package_name': 'com.android.webview.chromium', # ???

[mkosiba (inactive), 2014/08/19 09:26:17]

#???
I don't know either :) Maybe ask cmp@?

[hjd, 2014/08/19 14:34:22]

I think I worked out what happened, package_name used to be how
you specified the intermediate directory, this one use of it
in java_apk seems to be left over from the refactoring.
I've uploaded a cl to remove it but for now I'll just change
this one to something more sane and update whichever patch lands
second.

+        'R_package': 'com.android.webview.chromium',
+        'R_package_relpath': 'com/android/webview/chromium',
+        'extensions_to_not_compress': 'pak',
+        'asset_location': '<(PRODUCT_DIR)/android_webview_assets',
+        'additional_input_paths': [
+          '<(PRODUCT_DIR)/android_webview_assets/webviewchromium.pak',
+          '<(PRODUCT_DIR)/android_webview_assets/en-US.pak',

[mkosiba (inactive), 2014/08/19 09:26:17]

we'll want a better solution for these than including them case-by-case. File a
bug + TODO since we don't need all of the locale .pak files for the telemetry
bot.

[hjd, 2014/08/19 14:34:22]

Done.

+        ],
+        'conditions': [
+          ['icu_use_data_file_flag==1', {
+            'additional_input_paths': [
+              '<(PRODUCT_DIR)/icudtl.dat',
+            ],
+          }],
+        ],
+      },
+      'copies': [
+          {
+          'destination': '<(PRODUCT_DIR)/android_webview_assets',
+          'conditions': [
+            ['icu_use_data_file_flag==1', {
+              'files': [
+                '<(PRODUCT_DIR)/icudtl.dat',
+              ],
+            }],
+          ],
+        },
+      ],'includes': [ '../build/java_apk.gypi' ],
+    },
+  ],
+}
+