Chromium Code Reviews| Index: dm/DMPipeTask.h |
| diff --git a/dm/DMSerializeTask.h b/dm/DMPipeTask.h |
| similarity index 54% |
| copy from dm/DMSerializeTask.h |
| copy to dm/DMPipeTask.h |
| index 30a4303b061e2e8eb3e0fa16abe488f5541709f6..417217d52ed713bbaafb0d35ed78f93b74b96bcb 100644 |
| --- a/dm/DMSerializeTask.h |
| +++ b/dm/DMPipeTask.h |
| @@ -1,5 +1,5 @@ |
| -#ifndef DMSerializeTask_DEFINED |
| -#define DMSerializeTask_DEFINED |
| +#ifndef DMPipeTask_DEFINED |
| +#define DMPipeTask_DEFINED |
| #include "DMTask.h" |
| #include "SkBitmap.h" |
| @@ -7,16 +7,18 @@ |
| #include "SkTemplates.h" |
| #include "gm.h" |
| -// Record a picture, serialize it, deserialize it, then draw it and compare to reference bitmap. |
| +// Sends a GM through a pipe, draws it, and compares against the reference bitmap. |
| namespace DM { |
| -class SerializeTask : public Task { |
| +class PipeTask : public Task { |
| public: |
| - SerializeTask(const Task& parent, |
| - skiagm::GM*, |
| - SkBitmap reference); |
| + PipeTask(const Task& parent, |
|
epoger
2013/10/28 17:42:15
please document the parameters
mtklein
2013/10/28 19:03:41
Done.
epoger
2013/10/28 19:36:25
Thanks.
I would prefer javadoc-style comments (as
mtklein
2013/10/28 19:41:48
This not being a library, seems like overkill.
|
| + skiagm::GM*, |
| + SkBitmap reference, |
| + bool crossProcess, |
| + bool sharedAddressSpace); |
| virtual void draw() SK_OVERRIDE; |
| virtual bool usesGpu() const SK_OVERRIDE { return false; } |
| @@ -24,6 +26,7 @@ public: |
| virtual SkString name() const SK_OVERRIDE { return fName; } |
| private: |
| + const uint32_t fFlags; |
| const SkString fName; |
| SkAutoTDelete<skiagm::GM> fGM; |
| const SkBitmap fReference; |
| @@ -31,4 +34,4 @@ private: |
| } // namespace DM |
| -#endif // DMSerializeTask_DEFINED |
| +#endif // DMPipeTask_DEFINED |