Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 #ifndef DMSerializeTask_DEFINED | 1 #ifndef DMPipeTask_DEFINED |
| 2 #define DMSerializeTask_DEFINED | 2 #define DMPipeTask_DEFINED |
| 3 | 3 |
| 4 #include "DMTask.h" | 4 #include "DMTask.h" |
| 5 #include "SkBitmap.h" | 5 #include "SkBitmap.h" |
| 6 #include "SkString.h" | 6 #include "SkString.h" |
| 7 #include "SkTemplates.h" | 7 #include "SkTemplates.h" |
| 8 #include "gm.h" | 8 #include "gm.h" |
| 9 | 9 |
| 10 // Record a picture, serialize it, deserialize it, then draw it and compare to r eference bitmap. | 10 // Sends a GM through a pipe, draws it, and compares against the reference bitma p. |
| 11 | 11 |
| 12 namespace DM { | 12 namespace DM { |
| 13 | 13 |
| 14 class SerializeTask : public Task { | 14 class PipeTask : public Task { |
| 15 | 15 |
| 16 public: | 16 public: |
| 17 SerializeTask(const Task& parent, | 17 PipeTask(const Task& parent, |
|
epoger
2013/10/28 17:42:15
please document the parameters
mtklein
2013/10/28 19:03:41
Done.
epoger
2013/10/28 19:36:25
Thanks.
I would prefer javadoc-style comments (as
mtklein
2013/10/28 19:41:48
This not being a library, seems like overkill.
| |
| 18 skiagm::GM*, | 18 skiagm::GM*, |
| 19 SkBitmap reference); | 19 SkBitmap reference, |
| 20 bool crossProcess, | |
| 21 bool sharedAddressSpace); | |
| 20 | 22 |
| 21 virtual void draw() SK_OVERRIDE; | 23 virtual void draw() SK_OVERRIDE; |
| 22 virtual bool usesGpu() const SK_OVERRIDE { return false; } | 24 virtual bool usesGpu() const SK_OVERRIDE { return false; } |
| 23 virtual bool shouldSkip() const SK_OVERRIDE; | 25 virtual bool shouldSkip() const SK_OVERRIDE; |
| 24 virtual SkString name() const SK_OVERRIDE { return fName; } | 26 virtual SkString name() const SK_OVERRIDE { return fName; } |
| 25 | 27 |
| 26 private: | 28 private: |
| 29 const uint32_t fFlags; | |
| 27 const SkString fName; | 30 const SkString fName; |
| 28 SkAutoTDelete<skiagm::GM> fGM; | 31 SkAutoTDelete<skiagm::GM> fGM; |
| 29 const SkBitmap fReference; | 32 const SkBitmap fReference; |
| 30 }; | 33 }; |
| 31 | 34 |
| 32 } // namespace DM | 35 } // namespace DM |
| 33 | 36 |
| 34 #endif // DMSerializeTask_DEFINED | 37 #endif // DMPipeTask_DEFINED |
| OLD | NEW |