Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Unified Diff: content/browser/geolocation/network_location_provider_unittest.cc

Issue 477633002: Rename various Geolocation bits for clarity and consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more rename. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/network_location_provider_unittest.cc
diff --git a/content/browser/geolocation/network_location_provider_unittest.cc b/content/browser/geolocation/network_location_provider_unittest.cc
index c574b7a7b96be0b578dd6c3e4a411e0d0f3b93c2..23bb75483e8d5cfad60af01e7aaf815b57d247a7 100644
--- a/content/browser/geolocation/network_location_provider_unittest.cc
+++ b/content/browser/geolocation/network_location_provider_unittest.cc
@@ -35,8 +35,8 @@ class MessageLoopQuitListener {
CHECK(client_message_loop_);
}
- void LocationUpdateAvailable(const LocationProvider* provider,
- const Geoposition& position) {
+ void OnLocationUpdate(const LocationProvider* provider,
+ const Geoposition& position) {
EXPECT_EQ(client_message_loop_, base::MessageLoop::current());
updated_provider_ = provider;
client_message_loop_->Quit();
@@ -473,9 +473,8 @@ TEST_F(GeolocationNetworkProviderTest, NoRequestOnStartupUntilWifiData) {
scoped_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
- provider->SetUpdateCallback(
- base::Bind(&MessageLoopQuitListener::LocationUpdateAvailable,
- base::Unretained(&listener)));
+ provider->SetUpdateCallback(base::Bind(
timvolodine 2014/08/14 17:32:28 nit: I actually prefer the previous formatting, bu
Michael van Ouwerkerk 2014/08/14 17:36:14 This is what 'git cl format' gave me. I try not to
+ &MessageLoopQuitListener::OnLocationUpdate, base::Unretained(&listener)));
main_message_loop_.RunUntilIdle();
EXPECT_FALSE(get_url_fetcher_and_advance_id())
« no previous file with comments | « content/browser/geolocation/network_location_provider.cc ('k') | content/browser/geolocation/network_location_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698