Athena: Adding basic resource management framework (un-/re-loading) of V2 applications

athena/content/app_registry_impl.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "athena/content/public/app_registry.h"
+
+#include "athena/content/app_activity_registry.h"
+#include "athena/content/public/app_content_delegate.h"
+
+namespace athena {
+
+class AppRegistryImpl : public AppRegistry {
+ public:
+  AppRegistryImpl();
+  virtual ~AppRegistryImpl();
+
+  // Overrides the used AppContentDelegate. This function will own it
+  // afterwards. A value of NULL is invalid.
+  virtual void SetDelegate(AppContentDelegate* delegate) OVERRIDE;
+
+  // Retrieves the application content delegate. The ownership remains with this
+  // class.
+  virtual AppContentDelegate* GetDelegate() OVERRIDE;
+
+  // Returns an |AppActivityRegistry| for a given activity |app_id| and
+  // |browser_context|.
+  virtual AppActivityRegistry* GetAppActivityRegistry(
+      const std::string& app_id,
+      content::BrowserContext* browser_context) OVERRIDE;
+
+  // Returns the number of registered applications.
+  virtual int NumberOfApplications() const OVERRIDE { return app_list_.size(); }
+
+ protected:
+  // Only the |AppActivityRegistry| can remove itself.
+  friend AppActivityRegistry;
+
+  // Removes an activity registry for an application from the list of known
+  // applications.
+  virtual void RemoveAppActivityRegistry(
+      AppActivityRegistry* registry) OVERRIDE;
+
+ private:
+  std::vector<AppActivityRegistry*> app_list_;
+
+  scoped_ptr<AppContentDelegate> delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(AppRegistryImpl);
+};
+
+namespace {
+
+// The global instance.
+AppRegistryImpl* instance = NULL;
+
+}  // namespace
+
+AppRegistryImpl::AppRegistryImpl() : delegate_(new AppContentDelegate) {}
+
+AppRegistryImpl::~AppRegistryImpl() {
+  DCHECK(app_list_.empty());
+}
+
+void AppRegistryImpl::SetDelegate(AppContentDelegate* delegate) {
+  DCHECK(delegate);
+  delegate_.reset(delegate);
+}
+
+AppContentDelegate* AppRegistryImpl::GetDelegate() {
+  return delegate_.get();
+}
+
+AppActivityRegistry* AppRegistryImpl::GetAppActivityRegistry(
+    const std::string& app_id,
+    content::BrowserContext* browser_context) {
+  // Search for an existing proxy.
+  for (std::vector<AppActivityRegistry*>::iterator it = app_list_.begin();
+       it != app_list_.end(); ++it) {
+    if ((*it)->app_id() == app_id &&
+        (*it)->browser_context() == browser_context)
+      return *it;
+  }
+
+  // Create and return a new application object.
+  AppActivityRegistry* app_activity_registry =
+      new AppActivityRegistry(app_id, browser_context);
+  app_list_.push_back(app_activity_registry);
+  return app_activity_registry;
+}
+
+void AppRegistryImpl::RemoveAppActivityRegistry(AppActivityRegistry* registry) {
+  std::vector<AppActivityRegistry*>::iterator item =
+      std::find(app_list_.begin(), app_list_.end(), registry);
+  CHECK(item != app_list_.end());
+  app_list_.erase(item);
+}
+
+// static
+void AppRegistry::Create() {
+  DCHECK(!instance);
+  instance = new AppRegistryImpl();
+}
+
+// static
+AppRegistry* AppRegistry::Get() {

[oshima, 2014/08/19 21:22:24]

DCHECK(instance);

[Mr4D (OOO till 08-26), 2014/08/20 14:34:39]

Done.

+  return instance;
+}
+
+// static
+void AppRegistry::ShutDown() {
+  if (instance)
+    delete instance;

[oshima, 2014/08/19 21:22:24]

DCHECK(instance);
delete instance;      (delete NULL is valid code)

[Mr4D (OOO till 08-26), 2014/08/20 14:34:39]

Done.

+  instance = NULL;
+}
+
+AppRegistry::AppRegistry() {}

[oshima, 2014/08/19 21:22:24]

can you set instance in ctor/dtor?

[Mr4D (OOO till 08-26), 2014/08/20 14:34:39]

dtor changed.

+AppRegistry::~AppRegistry() {}
+
+}  // namespace athena