Issue 477483002: gn: use root_build_dir instead of . for rebase_path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 477483002: gn: use root_build_dir instead of . for rebase_path (Closed)

Created:
6 years, 4 months ago by scottmg

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

gn yasm: use root_build_dir instead of . for rebase_path I think these should be relative to the root_build_dir not the BUILD.gn dir (which is what "." is right?). It was working before if you happen to use (say) out\Default as the GN directory, but I've been using out_gn so there was an extra .. in the path. Also, a missing size_t->int warning disable on Windows. R=brettw@chromium.org BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289813

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	third_party/yasm/BUILD.gn	View		4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/477483002/1

6 years, 4 months ago (2014-08-14 23:00:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 289813

Expand Messages | Collapse Messages