Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/yasm/BUILD.gn

Issue 477483002: gn: use root_build_dir instead of . for rebase_path (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/BUILD.gn
diff --git a/third_party/yasm/BUILD.gn b/third_party/yasm/BUILD.gn
index 34638520e78b74e540bd1517df6ef7c9c10acbb6..812be9a6c43ac48408218e101066723842adc5ce 100644
--- a/third_party/yasm/BUILD.gn
+++ b/third_party/yasm/BUILD.gn
@@ -121,6 +121,8 @@ if (current_toolchain == host_toolchain) {
# re2c is missing CLOSEVOP from one switch.
if (is_posix) {
cflags = [ "-Wno-switch" ]
+ } else if (is_win) {
+ cflags = [ "/wd4267" ] # size_t to int conversion.
}
}
@@ -254,7 +256,7 @@ if (current_toolchain == host_toolchain) {
outputs = [ "$target_gen_dir/{{source_name_part}}.c" ]
args = [
"{{source}}",
- rebase_path(target_gen_dir, ".") + "/{{source_name_part}}.c",
+ rebase_path(target_gen_dir, root_build_dir) + "/{{source_name_part}}.c",
]
deps = [
":generate_x86_insn"
@@ -278,7 +280,8 @@ if (current_toolchain == host_toolchain) {
outputs = [ "$yasm_gen_include_dir/{{source_name_part}}.c" ]
args = [
"{{source}}",
- rebase_path(yasm_gen_include_dir, ".") + "/{{source_name_part}}.c",
+ rebase_path(yasm_gen_include_dir, root_build_dir) +
+ "/{{source_name_part}}.c",
]
deps = [
":generate_x86_insn"
@@ -343,7 +346,7 @@ if (current_toolchain == host_toolchain) {
args = [
"-b",
"-o",
- rebase_path(target_gen_dir, ".") + "/{{source_name_part}}.c",
+ rebase_path(target_gen_dir, root_build_dir) + "/{{source_name_part}}.c",
"{{source}}",
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698