core/include/fpdfapi/fpdf_pageobj.h - Issue 477323002: Font is used after release in CPDF_TextStateData::~CPDF_TextStateData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_pageobj.h

Issue 477323002: Font is used after release in CPDF_TextStateData::~CPDF_TextStateData (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/include/fpdfapi/fpdf_pageobj.h

diff --git a/core/include/fpdfapi/fpdf_pageobj.h b/core/include/fpdfapi/fpdf_pageobj.h

index 90e1b0b90b84a4aa8b8121ec1286b6d79cad27de..307fb16bdfbcbab831e6faa0ce58a19ca80644c6 100644

--- a/core/include/fpdfapi/fpdf_pageobj.h

+++ b/core/include/fpdfapi/fpdf_pageobj.h

@@ -220,6 +220,8 @@ public:

CPDF_Font* m_pFont;

+ CPDF_Document* m_pDocument;

Tom Sepez 2014/08/18 18:19:31 Are we sure that this object doesn't ever out-live

jun_fang 2014/08/18 20:33:54 Sorry. Can you explain your question more? I don't

FX_FLOAT m_FontSize;

FX_FLOAT m_CharSpace;

« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('j') | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('J')