Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Side by Side Diff: core/include/fpdfapi/fpdf_pageobj.h

Issue 477323002: Font is used after release in CPDF_TextStateData::~CPDF_TextStateData (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef _FPDF_PAGEOBJ_H_ 7 #ifndef _FPDF_PAGEOBJ_H_
8 #define _FPDF_PAGEOBJ_H_ 8 #define _FPDF_PAGEOBJ_H_
9 #ifndef _FPDF_RESOURCE_ 9 #ifndef _FPDF_RESOURCE_
10 #include "fpdf_resource.h" 10 #include "fpdf_resource.h"
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 public: 213 public:
214 214
215 CPDF_TextStateData(); 215 CPDF_TextStateData();
216 216
217 CPDF_TextStateData(const CPDF_TextStateData& src); 217 CPDF_TextStateData(const CPDF_TextStateData& src);
218 218
219 ~CPDF_TextStateData(); 219 ~CPDF_TextStateData();
220 220
221 CPDF_Font* m_pFont; 221 CPDF_Font* m_pFont;
222 222
223 CPDF_Document* m_pDocument;
Tom Sepez 2014/08/18 18:19:31 Are we sure that this object doesn't ever out-live
jun_fang 2014/08/18 20:33:54 Sorry. Can you explain your question more? I don't
224
223 FX_FLOAT m_FontSize; 225 FX_FLOAT m_FontSize;
224 226
225 FX_FLOAT m_CharSpace; 227 FX_FLOAT m_CharSpace;
226 228
227 FX_FLOAT m_WordSpace; 229 FX_FLOAT m_WordSpace;
228 230
229 FX_FLOAT m_Matrix[4]; 231 FX_FLOAT m_Matrix[4];
230 232
231 int m_TextMode; 233 int m_TextMode;
232 234
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 CFX_DIBitmap* m_pBitmap; 714 CFX_DIBitmap* m_pBitmap;
713 715
714 CFX_ArrayTemplate<CFX_AffineMatrix> m_Matrices; 716 CFX_ArrayTemplate<CFX_AffineMatrix> m_Matrices;
715 717
716 void AddMatrix(CFX_AffineMatrix& matrix); 718 void AddMatrix(CFX_AffineMatrix& matrix);
717 protected: 719 protected:
718 virtual void Transform(const CFX_AffineMatrix& matrix) {} 720 virtual void Transform(const CFX_AffineMatrix& matrix) {}
719 virtual void CopyData(const CPDF_PageObject* pSrcObjet) {} 721 virtual void CopyData(const CPDF_PageObject* pSrcObjet) {}
720 }; 722 };
721 #endif 723 #endif
OLDNEW
« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('j') | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698