Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: extensions/renderer/set_icon_natives.h

Issue 477193003: Refactor setIcon to allow for more general use of imageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar minor changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/set_icon.js ('k') | extensions/renderer/set_icon_natives.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/set_icon_natives.h
diff --git a/extensions/renderer/set_icon_natives.h b/extensions/renderer/set_icon_natives.h
index e5129dd976b3690985a6b2f60f320774ae849540..0def0be51fb886f7be8944b64666d3ec0a4201bc 100644
--- a/extensions/renderer/set_icon_natives.h
+++ b/extensions/renderer/set_icon_natives.h
@@ -24,10 +24,10 @@ class SetIconNatives : public ObjectBackedNativeHandler {
private:
bool ConvertImageDataToBitmapValue(const v8::Local<v8::Object> image_data,
- base::Value** bitmap_value);
+ v8::Local<v8::Value>* image_data_bitmap);
bool ConvertImageDataSetToBitmapValueSet(
- const v8::FunctionCallbackInfo<v8::Value>& args,
- base::DictionaryValue* bitmap_value);
+ v8::Local<v8::Object>& details,
+ v8::Local<v8::Object>* bitmap_set_value);
void SetIconCommon(const v8::FunctionCallbackInfo<v8::Value>& args);
RequestSender* request_sender_;
« no previous file with comments | « extensions/renderer/resources/set_icon.js ('k') | extensions/renderer/set_icon_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698