Refactor setIcon to allow for more general use of imageData

extensions/renderer/set_icon_natives.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SET_ICON_NATIVES_H_
 #define EXTENSIONS_RENDERER_SET_ICON_NATIVES_H_
 
 #include "extensions/renderer/object_backed_native_handler.h"
 #include "v8/include/v8.h"
 
 namespace base {
 class DictionaryValue;
 class Value;
 }
 
 namespace extensions {
 class RequestSender;
 class ScriptContext;
 
 // Functions exposed to extension JS to implement the setIcon extension API.
 class SetIconNatives : public ObjectBackedNativeHandler {
  public:
   SetIconNatives(RequestSender* request_sender, ScriptContext* context);
 
  private:
   bool ConvertImageDataToBitmapValue(const v8::Local<v8::Object> image_data,
-                                     base::Value** bitmap_value);
+                                     v8::Local<v8::Value>* image_data_bitmap);
   bool ConvertImageDataSetToBitmapValueSet(
-      const v8::FunctionCallbackInfo<v8::Value>& args,
-      base::DictionaryValue* bitmap_value);
+      v8::Local<v8::Object>& details,
+      v8::Local<v8::Object>* bitmap_set_value);
   void SetIconCommon(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   RequestSender* request_sender_;
 
   DISALLOW_COPY_AND_ASSIGN(SetIconNatives);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SET_ICON_NATIVES_H_