Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 477173002: Fix delay load of (Un)RegisterPowerSettingNotification on Win XP. (Closed)

Created:
6 years, 4 months ago by timvolodine
Modified:
6 years, 4 months ago
Reviewers:
jschuh, jam, jabdelmalek, scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix delay load of (Un)RegisterPowerSettingNotification on Win XP. Without this some telemetry tests and canary XP build fail to load. BUG=404175 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/chrome.user32.delay.imports View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
timvolodine
6 years, 4 months ago (2014-08-15 16:35:35 UTC) #1
scottmg
lgtm (trying to file a bug so we can make this less crazy, but crbug ...
6 years, 4 months ago (2014-08-15 16:49:17 UTC) #2
jschuh
lgtm. thanks for following up
6 years, 4 months ago (2014-08-15 16:53:36 UTC) #3
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-15 17:02:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/477173002/1
6 years, 4 months ago (2014-08-15 17:03:47 UTC) #5
timvolodine
+ jam : need an OWNER
6 years, 4 months ago (2014-08-15 17:10:13 UTC) #6
jabdelmalek
lgtm
6 years, 4 months ago (2014-08-15 17:20:17 UTC) #7
jam
lgtm
6 years, 4 months ago (2014-08-15 17:20:24 UTC) #8
timvolodine
The CQ bit was unchecked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-15 17:22:05 UTC) #9
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-15 17:22:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/477173002/1
6 years, 4 months ago (2014-08-15 17:24:16 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:47:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 289956

Powered by Google App Engine
This is Rietveld 408576698