Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 477153005: DevTools: adopt existing Timeline tests for tracing based Timeline (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: adopt existing Timeline tests for tracing based Timeline All existing timeline tests under inspector/timeline and http/tests/inspector are copied into inspector/tracing and http/tests/tracing correspondingly. All tests under .../inspector/timeline/tracing are moved to .../inspector/tracing too. In that folder the tests are run with "Timeline based on trace events" experiment on (see changes in InspectorView.js), while the old tests continue to use old Timeline implementation. We are going to keep both implementations and tests for them until we are sure that the new implementation is stable enough and can be moved out of experimental. At that point old implementation will be removed along with the old tests. BUG=398785 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180815

Patch Set 1 #

Patch Set 2 : Restored old tests #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : Added FIXME to InspectorView.js #

Patch Set 5 : Addressed Andrey's comments #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1237 lines, -1126 lines) Patch
M LayoutTests/FlakyTests View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/timeline-xhr-event.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt View 4 chunks +22 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/timeline-xhr-response-type-blob-event.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/timeline-xhr-response-type-blob-event-expected.txt View 4 chunks +22 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/websocket/timeline-websocket-event.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/inspector/tracing/websocket/timeline-websocket-event-expected.txt View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/buffer-usage.html View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/buffer-usage-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/decode-resize.html View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/decode-resize-expected.txt View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/frame-model.html View 1 2 1 chunk +0 lines, -243 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/frame-model-expected.txt View 1 2 1 chunk +0 lines, -205 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/resources/worker.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/timeline-model.html View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/timeline-model-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/tracing-timeline-load.html View 1 2 1 chunk +0 lines, -124 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/tracing-timeline-load-expected.txt View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/update-layer-tree.html View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/update-layer-tree-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/worker-events.html View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/inspector/timeline/tracing/worker-events-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
A + LayoutTests/inspector/tracing/anonymous-image-object.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/anonymous-image-object-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/buffer-usage.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/buffer-usage-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/category-filter.html View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/category-filter-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/decode-resize.html View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
A + LayoutTests/inspector/tracing/decode-resize-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/fix_all View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/fix_path View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/frame-model.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/frame-model-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/resources/anImage.png View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/anotherImage.png View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/big.png View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.bmp View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.gif View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.ico View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.jpg View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.png View 1 2 Binary file 0 comments Download
A + LayoutTests/inspector/tracing/resources/test.webp View 1 2 Binary file 0 comments Download
A LayoutTests/inspector/tracing/resources/timeline-data.js View 1 2 1 chunk +460 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/resources/timeline-iframe-data.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/resources/timeline-iframe-paint.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/resources/worker.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-animation-frame.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-animation-frame-expected.txt View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-auto-record.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-auto-record-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-bound-function.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-bound-function-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-coalescing.html View 1 2 3 4 1 chunk +140 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-coalescing-expected.txt View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-dfs.html View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-dfs-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-dom-content-loaded-event.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-dom-content-loaded-event-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-enum-stability.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-enum-stability-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-event-dispatch.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-event-dispatch-expected.txt View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-filtering.html View 1 2 3 4 1 chunk +113 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-filtering-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-flame-chart-automatically-size-window-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-gc-event.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-gc-event-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-injected-script-eval.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-layout.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-layout-expected.txt View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-layout-reason.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-layout-reason-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-load.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-load-event.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-load-event-expected.txt View 1 2 2 chunks +2 lines, -22 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-load-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-mark-timeline.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-model.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-model-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-network-received-data.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-network-received-data-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-network-resource.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-network-resource.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-network-resource-expected.txt View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-node-reference.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-node-reference-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-parse-html.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-parse-html-expected.txt View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-recalculate-styles.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-recalculate-styles-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-receive-response-event.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-records-cleared.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-records-cleared-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-id.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-id-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-tag-1.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-tag-1-expected.txt View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-tag-2.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-tag-2.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-script-tag-2-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/inspector/tracing/timeline-time.html View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-time-expected.txt View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-time-stamp.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-time-stamp-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-timer.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-timer-expected.txt View 1 2 11 chunks +11 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-trivial.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-trivial-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-window-filter.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-window-filter-expected.txt View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/trace-event-self-time.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/trace-event-self-time-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/tracing-timeline-load.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/update-layer-tree.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/update-layer-tree-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/worker-events.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/inspector/tracing/worker-events-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/virtual/deferred/inspector/tracing/README.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A + LayoutTests/virtual/deferred/inspector/tracing/timeline-paint-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/tracing/paint-command-log-nodes.html View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/tracing/paint-command-log-nodes-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
A + LayoutTests/virtual/implsidepainting/inspector/tracing/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/implsidepainting/inspector/tracing/paint-command-log-nodes.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/virtual/implsidepainting/inspector/tracing/paint-command-log-nodes-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/virtual/implsidepainting/inspector/tracing/timeline-paint-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
yurys
6 years, 4 months ago (2014-08-22 09:06:22 UTC) #1
yurys
The new modified tests were extracted from https://codereview.chromium.org/481403002/
6 years, 4 months ago (2014-08-22 09:07:14 UTC) #2
yurys
PTAL
6 years, 4 months ago (2014-08-22 10:48:10 UTC) #3
caseq
https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js File LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js#newcode111 LayoutTests/http/tests/inspector/timeline-test.js:111: tracingModel._tracingStarted(sessionId); use WebInspector.inspectorView.showPanel("timeline")._model.setEventsForTest() instead? https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt File LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt (right): https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt#newcode7 ...
6 years, 4 months ago (2014-08-22 11:11:30 UTC) #4
yurys
https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js File LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js#newcode111 LayoutTests/http/tests/inspector/timeline-test.js:111: tracingModel._tracingStarted(sessionId); On 2014/08/22 11:11:30, caseq wrote: > use WebInspector.inspectorView.showPanel("timeline")._model.setEventsForTest() ...
6 years, 4 months ago (2014-08-22 11:28:09 UTC) #5
caseq
On 2014/08/22 11:28:09, yurys wrote: > https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js > File LayoutTests/http/tests/inspector/timeline-test.js (right): > > https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js#newcode111 > ...
6 years, 4 months ago (2014-08-22 11:39:01 UTC) #6
yurys
On 2014/08/22 11:39:01, caseq wrote: > On 2014/08/22 11:28:09, yurys wrote: > > > https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js ...
6 years, 4 months ago (2014-08-22 11:41:49 UTC) #7
caseq
https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt File LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt (right): https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt#newcode7 LayoutTests/http/tests/inspector/tracing/timeline-xhr-event-expected.txt:7: readyState : 1 On 2014/08/22 11:28:08, yurys wrote: > ...
6 years, 4 months ago (2014-08-22 11:44:45 UTC) #8
yurys
PTAL https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js File LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/477153005/diff/40001/LayoutTests/http/tests/inspector/timeline-test.js#newcode111 LayoutTests/http/tests/inspector/timeline-test.js:111: tracingModel._tracingStarted(sessionId); On 2014/08/22 11:11:30, caseq wrote: > use ...
6 years, 4 months ago (2014-08-22 12:15:58 UTC) #9
caseq
lgtm
6 years, 4 months ago (2014-08-22 12:29:35 UTC) #10
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-22 13:10:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/477153005/100001
6 years, 4 months ago (2014-08-22 13:10:58 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 13:56:14 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 13:58:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8303)
6 years, 4 months ago (2014-08-22 13:58:49 UTC) #15
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-22 14:17:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/477153005/100001
6 years, 4 months ago (2014-08-22 14:18:21 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 14:28:56 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 14:31:40 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8310)
6 years, 4 months ago (2014-08-22 14:31:42 UTC) #20
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-23 11:35:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/477153005/100001
6 years, 4 months ago (2014-08-23 11:36:07 UTC) #22
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 04:55:14 UTC) #23
Message was sent while issue was closed. 
Committed patchset #6 (100001) as 180815

Powered by Google App Engine
This is Rietveld 408576698