build/android/pylib/android_commands.py - Issue 477153003: [Android] Make adb shell commands with single quotes run correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 477153003: [Android] Make adb shell commands with single quotes run correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 5fc2fbd0b001ba6d22e338f35371c255357fd24a..7c73b526da7e35f42e32da4e7e6b8e4a7b49a62a 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -713,7 +713,7 @@ class AndroidCommands(object):

"""

self._LogShell(command)

if "'" in command:

- logging.warning(command + " contains ' quotes")

+ command = command.replace('\'', '\'\\\'\'')

result = self._adb.SendShellCommand(

"'%s'" % command, timeout_time).splitlines()

# TODO(b.kelemen): we should really be able to drop the stderr of the

« no previous file with comments | « no previous file | build/android/pylib/device_settings.py » ('j') | no next file with comments »