build/android/pylib/device_settings.py - Issue 477153003: [Android] Make adb shell commands with single quotes run correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device_settings.py

Issue 477153003: [Android] Make adb shell commands with single quotes run correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/device_settings.py

diff --git a/build/android/pylib/device_settings.py b/build/android/pylib/device_settings.py

index 3612a81f66be947e1020da77f0fac43af555477c..ec8a79ace2570155f60ff36cea3d379f898090e3 100644

--- a/build/android/pylib/device_settings.py

+++ b/build/android/pylib/device_settings.py

@@ -93,7 +93,7 @@ commit transaction;""" % {

'columns': ', '.join(columns),

'values': ', '.join(["'%s'" % value for value in values])

}

- output_msg = device.RunShellCommand('\'sqlite3 %s "%s"\'' % (db, cmd))

+ output_msg = device.RunShellCommand('sqlite3 %s "%s"' % (db, cmd))

if output_msg:

print ' '.join(output_msg)

« no previous file with comments | « build/android/pylib/android_commands.py ('k') | no next file » | no next file with comments »