Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 477153003: [Android] Make adb shell commands with single quotes run correctly. (Closed)

Created:
6 years, 4 months ago by jbudorick
Modified:
6 years, 4 months ago
Reviewers:
klundberg, navabi1, tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Make adb shell commands with single quotes run correctly. BUG=401163 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290299

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device_settings.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jbudorick
6 years, 4 months ago (2014-08-15 19:16:24 UTC) #1
klundberg
lgtm
6 years, 4 months ago (2014-08-15 20:09:47 UTC) #2
navabi1
lgtm
6 years, 4 months ago (2014-08-18 17:14:34 UTC) #3
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 17:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/477153003/20001
6 years, 4 months ago (2014-08-18 17:17:08 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 18:05:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290299

Powered by Google App Engine
This is Rietveld 408576698