Use a real version string for app_shell

extensions/shell/browser/shell_nacl_browser_delegate.cc

Index: extensions/shell/browser/shell_nacl_browser_delegate.cc
diff --git a/extensions/shell/browser/shell_nacl_browser_delegate.cc b/extensions/shell/browser/shell_nacl_browser_delegate.cc
index a9b01e0dde49508a73bc8b9bca722b0f39a3f339..493be884290793f66714bedabd7d7bdf2dd6cd33 100644
--- a/extensions/shell/browser/shell_nacl_browser_delegate.cc
+++ b/extensions/shell/browser/shell_nacl_browser_delegate.cc
@@ -20,6 +20,7 @@
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/url_pattern.h"
+#include "extensions/shell/common/version.h"  // Generated file.
 #include "ppapi/c/private/ppb_nacl_private.h"
 #include "url/gurl.h"
 
@@ -109,10 +110,9 @@ bool ShellNaClBrowserDelegate::GetUserDirectory(base::FilePath* user_dir) {
 }
 
 std::string ShellNaClBrowserDelegate::GetVersionString() const {
-  // Used to trigger update of the validation caches.
-  // TODO(jamescook): Generate a real version number and use it both here and
-  // in our user agent. http://crbug.com/402612
-  return "1.2.3.4";
+  // A version changes triggers an update of the NaCl validation caches.

[Daniel Erat, 2014/08/19 18:25:14]

nit: s/changes/change/

[James Cook, 2014/08/19 18:27:44]

Done.

+  // Example version: "39.0.2129.0 (290550)".
+  return PRODUCT_VERSION " (" LAST_CHANGE ")";
 }
 
 ppapi::host::HostFactory* ShellNaClBrowserDelegate::CreatePpapiHostFactory(