Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 476953003: Fix for pixel-moving CSS filters with clipping. (Closed)

Created:
6 years, 4 months ago by Stephen White
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Fix for pixel-moving CSS filters with clipping. When using a "pixel-moving" filter (ie., drop-shadow or blur), we disable the normal clip operation, since we want to want to render the full results of the element pre-clip for filtering. Clipping is then applied just before drawing the filtered result. However, we shouldn't disable *all* clipping recursively, since we want children which clip themselves to still continue to be clipped. The fix is to pass the original (unmodified) paintingInfo to paintChildren(). BUG=350411 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180361

Patch Set 1 #

Patch Set 2 : Add DOCTYPE to test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
A LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/css3/filters/effect-drop-shadow-clip-abspos-expected.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen White
esprehn: PTAL. Thanks!
6 years, 4 months ago (2014-08-14 22:21:01 UTC) #1
esprehn
Lgtm, please add a doctype to the test :)
6 years, 4 months ago (2014-08-14 22:24:05 UTC) #2
Stephen White
On 2014/08/14 22:24:05, esprehn wrote: > Lgtm, please add a doctype to the test :) ...
6 years, 4 months ago (2014-08-15 11:44:22 UTC) #3
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 4 months ago (2014-08-15 11:46:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/476953003/20001
6 years, 4 months ago (2014-08-15 11:46:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-15 12:44:33 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 14:37:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180361

Powered by Google App Engine
This is Rietveld 408576698