Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 476953003: Fix for pixel-moving CSS filters with clipping. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add DOCTYPE to test files Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/css3/filters/effect-drop-shadow-clip-abspos-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1837 matching lines...) Expand 10 before | Expand all | Expand 10 after
1848 shouldRespectOverflowClip(paintFlags, renderer()), &offsetFromRoot, localPaintingInfo.subPixelAccumulation); 1848 shouldRespectOverflowClip(paintFlags, renderer()), &offsetFromRoot, localPaintingInfo.subPixelAccumulation);
1849 updatePaintingInfoForFragments(layerFragments, localPaintingInfo, paintF lags, shouldPaintContent, &offsetFromRoot); 1849 updatePaintingInfoForFragments(layerFragments, localPaintingInfo, paintF lags, shouldPaintContent, &offsetFromRoot);
1850 } 1850 }
1851 1851
1852 if (shouldPaintBackground) { 1852 if (shouldPaintBackground) {
1853 paintBackgroundForFragments(layerFragments, context, transparencyLayerCo ntext, paintingInfo.paintDirtyRect, haveTransparency, 1853 paintBackgroundForFragments(layerFragments, context, transparencyLayerCo ntext, paintingInfo.paintDirtyRect, haveTransparency,
1854 localPaintingInfo, paintBehavior, paintingRootForRenderer, paintFlag s); 1854 localPaintingInfo, paintBehavior, paintingRootForRenderer, paintFlag s);
1855 } 1855 }
1856 1856
1857 if (shouldPaintNegZOrderList) 1857 if (shouldPaintNegZOrderList)
1858 paintChildren(NegativeZOrderChildren, context, localPaintingInfo, paintF lags); 1858 paintChildren(NegativeZOrderChildren, context, paintingInfo, paintFlags) ;
1859 1859
1860 if (shouldPaintOwnContents) { 1860 if (shouldPaintOwnContents) {
1861 paintForegroundForFragments(layerFragments, context, transparencyLayerCo ntext, paintingInfo.paintDirtyRect, haveTransparency, 1861 paintForegroundForFragments(layerFragments, context, transparencyLayerCo ntext, paintingInfo.paintDirtyRect, haveTransparency,
1862 localPaintingInfo, paintBehavior, paintingRootForRenderer, selection Only, paintFlags); 1862 localPaintingInfo, paintBehavior, paintingRootForRenderer, selection Only, paintFlags);
1863 } 1863 }
1864 1864
1865 if (shouldPaintOutline) 1865 if (shouldPaintOutline)
1866 paintOutlineForFragments(layerFragments, context, localPaintingInfo, pai ntBehavior, paintingRootForRenderer, paintFlags); 1866 paintOutlineForFragments(layerFragments, context, localPaintingInfo, pai ntBehavior, paintingRootForRenderer, paintFlags);
1867 1867
1868 if (shouldPaintNormalFlowAndPosZOrderLists) 1868 if (shouldPaintNormalFlowAndPosZOrderLists)
1869 paintChildren(NormalFlowChildren | PositiveZOrderChildren, context, loca lPaintingInfo, paintFlags); 1869 paintChildren(NormalFlowChildren | PositiveZOrderChildren, context, pain tingInfo, paintFlags);
1870 1870
1871 if (shouldPaintOverlayScrollbars) 1871 if (shouldPaintOverlayScrollbars)
1872 paintOverflowControlsForFragments(layerFragments, context, localPainting Info, paintFlags); 1872 paintOverflowControlsForFragments(layerFragments, context, localPainting Info, paintFlags);
1873 1873
1874 if (filterPainter.hasStartedFilterEffect()) { 1874 if (filterPainter.hasStartedFilterEffect()) {
1875 // Apply the correct clipping (ie. overflow: hidden). 1875 // Apply the correct clipping (ie. overflow: hidden).
1876 // FIXME: It is incorrect to just clip to the damageRect here once multi ple fragments are involved. 1876 // FIXME: It is incorrect to just clip to the damageRect here once multi ple fragments are involved.
1877 ClipRect backgroundRect = layerFragments.isEmpty() ? ClipRect() : layerF ragments[0].backgroundRect; 1877 ClipRect backgroundRect = layerFragments.isEmpty() ? ClipRect() : layerF ragments[0].backgroundRect;
1878 clipToRect(localPaintingInfo, transparencyLayerContext, backgroundRect, paintFlags); 1878 clipToRect(localPaintingInfo, transparencyLayerContext, backgroundRect, paintFlags);
1879 context = filterPainter.applyFilterEffect(); 1879 context = filterPainter.applyFilterEffect();
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
3686 } 3686 }
3687 } 3687 }
3688 3688
3689 void showLayerTree(const blink::RenderObject* renderer) 3689 void showLayerTree(const blink::RenderObject* renderer)
3690 { 3690 {
3691 if (!renderer) 3691 if (!renderer)
3692 return; 3692 return;
3693 showLayerTree(renderer->enclosingLayer()); 3693 showLayerTree(renderer->enclosingLayer());
3694 } 3694 }
3695 #endif 3695 #endif
OLDNEW
« no previous file with comments | « LayoutTests/css3/filters/effect-drop-shadow-clip-abspos-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698