Issue 476913002: [NOT SUBMITTED] Removed DCHECK to allow external code to check if v8 platform is initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 476913002: [NOT SUBMITTED] Removed DCHECK to allow external code to check if v8 platform is initialized. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer, jam, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Removed DCHECK to allow external code to check if v8 platform is initialized. DCHECK is not nessesary here, becase any V8::GetCurrentPlatform()-> would crash anyway. BUG=403851

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/v8.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

On 2014/08/18 08:06:02, Benedikt Meurer wrote: > lgtm I am not going to implement workaround ...

6 years, 4 months ago (2014-08-18 08:37:55 UTC) #4

Yang

6 years, 4 months ago (2014-08-18 08:40:32 UTC) #5

On 2014/08/18 08:37:55, Vitaly Buka wrote:
> On 2014/08/18 08:06:02, Benedikt Meurer wrote:
> > lgtm
> 
> I am not going to implement workaround as suggested in attached bug.
> Still I think this DCHECK is unnecessary.
> Should I submit or delete this patch?

Let's not land this. DCHECKs are debug mode only anyways, and it might help
catching bugs for the case when the return value is not immediately
dereferenced.

Expand Messages | Collapse Messages