Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: Tools/GardeningServer/ui/ct-results-panel.html

Issue 476903004: [sheriff-o-matic]: Basic trooper display for sheriff-o-matic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-panel.html
diff --git a/Tools/GardeningServer/ui/ct-results-panel.html b/Tools/GardeningServer/ui/ct-results-panel.html
index c753a8cbc02705047d5525b6701584fb69f5697f..fec45b4d986dece05ba05c672aa975dc8da809e0 100644
--- a/Tools/GardeningServer/ui/ct-results-panel.html
+++ b/Tools/GardeningServer/ui/ct-results-panel.html
@@ -29,6 +29,10 @@ found in the LICENSE file.
text-align: center;
}
+ iframe {
+ height: 100%;
+ }
+
core-menu {
box-shadow: 0 3px 3px #ccc;
flex: none;
@@ -47,9 +51,12 @@ found in the LICENSE file.
padding-top: 6px;
}
</style>
- <template if="{{ !failures.length }}">
+ <template if="{{ !(failures.length || failures.url) }}">
ojan 2014/09/04 02:58:43 Nit: I prefer inverting these sorts of bools inste
shans 2014/09/05 00:08:20 Done.
<div class="message">No results to display.</div>
</template>
+ <template if="{{ failures.url }}">
+ <iframe src='{{ failures.url }}'></iframe>
ojan 2014/09/04 02:58:43 Indentation is off.
shans 2014/09/05 00:08:20 Done.
+ </template>
<template if="{{ failures.length }}">
<core-menu selected="{{ selected }}">
<template repeat="{{ failure in failures }}">

Powered by Google App Engine
This is Rietveld 408576698