Chromium Code Reviews| Index: Tools/GardeningServer/ui/ct-failure-card.html |
| diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html |
| index 84dca8b99bc095496a5a6785ab3384426da56358..64fc473a589dac775e1af8a2212ca8863ccdaffd 100644 |
| --- a/Tools/GardeningServer/ui/ct-failure-card.html |
| +++ b/Tools/GardeningServer/ui/ct-failure-card.html |
| @@ -4,9 +4,8 @@ Use of this source code is governed by a BSD-style license that can be |
| found in the LICENSE file. |
| --> |
| -<link rel="import" href="ct-builder-grid.html"> |
| -<link rel="import" href="ct-commit-list.html"> |
| -<link rel="import" href="ct-test-list.html"> |
| +<link rel="import" href="ct-bot-failure-card.html"> |
| +<link rel="import" href="ct-trooper-card.html"> |
| <link rel="import" href="../bower_components/paper-dialog/paper-dialog.html"> |
| <link rel="import" href="../bower_components/paper-dialog/paper-dialog-transition.html"> |
| <link rel="import" href="../bower_components/paper-input/paper-input.html"> |
| @@ -47,28 +46,27 @@ found in the LICENSE file. |
| color: #222; |
| } |
| - ct-builder-grid { |
| - margin-right: 10px; |
| - width: 250px; |
| - } |
| - |
| - #failure { |
| - flex: 1; |
| - } |
| - |
| #buttons { |
| display: flex; |
| flex-direction: column; |
| } |
| + .card { |
| + display: flex; |
| + flex: 1; |
| + } |
| + |
| .snoozed { |
| opacity: 0.5; |
| } |
| </style> |
| - <ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid> |
| - <div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}"> |
| - <ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list> |
| - <ct-commit-list commitList="{{ group.commitList }}"></ct-commit-list> |
| + <div class="{{ { snoozed: group.isSnoozed, card: true } | tokenList }}"> |
|
ojan
2014/09/04 02:58:43
"card {{ { snoozed: ... } | tokenList }}"
shans
2014/09/05 00:08:20
Done.
|
| + <template if="{{ group.data.type == 'sheriff' }}"> |
| + <ct-bot-failure-card class='card' group="{{ group.data }}"></ct-bot-failure-card> |
| + </template> |
| + <template if="{{ group.data.type != 'sheriff' }}"> |
|
ojan
2014/09/04 02:58:43
Nit: how about == 'trooper' instead?
shans
2014/09/05 00:08:20
I'd need to add a sub-type field. type currently c
|
| + <ct-trooper-card class='card' group="{{ group.data }}"></ct-trooper-card> |
| + </template> |
| </div> |
| <div id="buttons"> |
| <paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button> |
| @@ -117,7 +115,7 @@ found in the LICENSE file. |
| }, |
| _updateCommitList: function() { |
| - if (this.group && this.commitLog) |
| + if (this.group && this.group.commitList && this.commitLog) |
|
ojan
2014/09/04 02:58:43
Isn't this still the card that doesn't have commit
shans
2014/09/05 00:08:19
No, this is the container of both card types decid
|
| this.group.commitList.update(this.commitLog); |
| }, |