[sheriff-o-matic]: Basic trooper display for sheriff-o-matic.

Tools/GardeningServer/ui/ct-failure-card.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
-<link rel="import" href="ct-builder-grid.html">
-<link rel="import" href="ct-commit-list.html">
-<link rel="import" href="ct-test-list.html">
+<link rel="import" href="ct-bot-failure-card.html">
+<link rel="import" href="ct-trooper-card.html">
 <link rel="import" href="../bower_components/paper-dialog/paper-dialog.html">
 <link rel="import" href="../bower_components/paper-dialog/paper-dialog-transition.html">
 <link rel="import" href="../bower_components/paper-input/paper-input.html">
 
 <polymer-element name="ct-failure-card" attributes="group commitLog tree bug">
   <template>
     <style>
       :host {
         display: flex;
       }
@@ skipping 20 matching lines @@
         box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.3);
       }
 
       paper-button:active, paper-button:hover {
         background: #f8f8f8;
         border-color: #c6c6c6;
         box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1);
         color: #222;
       }
 
-      ct-builder-grid {
-        margin-right: 10px;
-        width: 250px;
-      }
-
-      #failure {
-        flex: 1;
-      }
-
       #buttons {
         display: flex;
         flex-direction: column;
       }
 
+      .card {
+        display: flex;
+        flex: 1;
+      }
+
       .snoozed {
         opacity: 0.5;
       }
     </style>
-    <ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
-    <div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
-      <ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
-      <ct-commit-list commitList="{{ group.commitList }}"></ct-commit-list>
+    <div class="{{ { snoozed: group.isSnoozed, card: true } | tokenList }}">

[ojan, 2014/09/04 02:58:43]

"card {{ { snoozed: ... } | tokenList }}"

[shans, 2014/09/05 00:08:20]

Done.

+      <template if="{{ group.data.type == 'sheriff' }}">
+        <ct-bot-failure-card class='card' group="{{ group.data }}"></ct-bot-failure-card>
+      </template>
+      <template if="{{ group.data.type != 'sheriff' }}">

[ojan, 2014/09/04 02:58:43]

Nit: how about == 'trooper' instead?

[shans, 2014/09/05 00:08:20]

I'd need to add a sub-type field. type currently contains 'cq_latency',
'tree_status', or 'build_times'.

+        <ct-trooper-card class='card' group="{{ group.data }}"></ct-trooper-card>
+      </template>
     </div>
     <div id="buttons">
       <paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
       <template if="{{ !group.isSnoozed }}">
         <paper-button id="snooze" on-tap="{{ snooze }}" label="Snooze"></paper-button>
       </template>
       <template if="{{ group.isSnoozed }}">
         <paper-button id="snooze" on-tap="{{ unsnooze }}" label="Unsnooze"></paper-button>
       </template>
       <paper-button id="link-bug" on-tap="{{ linkBug }}" label="Link Bug"></paper-button>
       <template if="{{ group.bug !== undefined }}">
         <div>
           <a href="{{ group.bug }}">
             {{ group.bugLabel }}</a>
         </div>
       </template>
     </div>
 
     <paper-dialog heading="Enter bug number" transition="paper-transition-center" id="bugDialog">
       <paper-input label="Bug# or URL" floatingLabel autofocus id="bug"></paper-input>
       <paper-button label="Remove bug link" on-tap="{{ removeBug }}" dismissive id="dialogRemoveBug"></paper-button>
       <paper-button label="OK" on-tap="{{ saveBug }}" affirmative id="dialogOk"></paper-button>
     </paper-dialog>
   </template>
   <script>
     Polymer({
       group: null,
       commitLog: null,

[ojan, 2014/09/04 02:58:43]

In this design we're still passing a commitLog where the trooper one doesn't
need to know that and we're passing a tree that is unused by the trooper card as
well.

[shans, 2014/09/05 00:08:19]

On the other hand, if we made trooper-card a sibling to this, then we'd need to
duplicate snooze/unsnooze/linkBug/saveBug/removeBug functionality across both
cards.

       tree: '',
 
       observe: {
         group: '_updateCommitList',
         commitLog: '_updateCommitList'
       },
 
       examine: function() {
         this.fire('ct-examine-failures', this.group);
       },
 
       snooze: function() {
         this.group.snoozeUntil(Date.now() + 60 * 60 * 1000);
       },
 
       unsnooze: function() {
         this.group.unsnooze();
       },
 
       _updateCommitList: function() {
-        if (this.group && this.commitLog)
+        if (this.group && this.group.commitList && this.commitLog)

[ojan, 2014/09/04 02:58:43]

Isn't this still the card that doesn't have commit lists knowing about commit
lists?

[shans, 2014/09/05 00:08:19]

No, this is the container of both card types deciding whether the card knows
about commit lists.

           this.group.commitList.update(this.commitLog);
       },
 
       linkBug: function() {
         this.$.bug.value = this.group.bug;
         this.$.bugDialog.toggle();
       },
 
       saveBug: function() {
         this.group.setBug(this.$.bug.value);
       },
 
       removeBug: function() {
         this.group.clearBug();
       },
     });
   </script>
 </polymer-element>