Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 476583002: Fix a bogus assertion in CLM (Closed)

Created:
6 years, 4 months ago by Ian Vollick
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix a bogus assertion in CLM In the CompositedLayerMapping's doPaintTask function we ASSERT that we never get here if we paint into our composited ancestor (i.e., we don't paint ourself). This doesn't make sense for the squashing layer. Even if the layer that owns the backing happens to paint into its ancestor, the squashed layers may well paint into the squashing layer. BUG=394413 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180328

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
A + LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html View 1 4 chunks +11 lines, -3 lines 0 comments Download
A + LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer-expected.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ian Vollick
6 years, 4 months ago (2014-08-14 20:41:11 UTC) #1
abarth-chromium
LGTM
6 years, 4 months ago (2014-08-14 20:56:02 UTC) #2
abarth-chromium
https://codereview.chromium.org/476583002/diff/80001/Source/core/rendering/compositing/CompositedLayerMapping.cpp File Source/core/rendering/compositing/CompositedLayerMapping.cpp (right): https://codereview.chromium.org/476583002/diff/80001/Source/core/rendering/compositing/CompositedLayerMapping.cpp#newcode2022 Source/core/rendering/compositing/CompositedLayerMapping.cpp:2022: } We should just make this a RELEASE_ASSERT
6 years, 4 months ago (2014-08-14 20:56:29 UTC) #3
Ian Vollick
On 2014/08/14 20:56:29, abarth wrote: > https://codereview.chromium.org/476583002/diff/80001/Source/core/rendering/compositing/CompositedLayerMapping.cpp > File Source/core/rendering/compositing/CompositedLayerMapping.cpp (right): > > https://codereview.chromium.org/476583002/diff/80001/Source/core/rendering/compositing/CompositedLayerMapping.cpp#newcode2022 > ...
6 years, 4 months ago (2014-08-15 03:00:38 UTC) #4
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 4 months ago (2014-08-15 03:00:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/476583002/120001
6 years, 4 months ago (2014-08-15 03:01:45 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 04:21:54 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 05:43:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (120001) as 180328

Powered by Google App Engine
This is Rietveld 408576698